Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug only when test manager is connected #1239

Merged
merged 1 commit into from
Jul 3, 2018
+9 −3
Merged

Debug only when test manager is connected #1239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/OmniSharp.DotNetTest/Services/DebugTestService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Composition;
using System;
using System.Composition;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis;
Expand Down Expand Up @@ -31,9 +32,14 @@ public DebugTestService(DebugSessionManager debugSessionManager, OmniSharpWorksp
public Task<DebugTestGetStartInfoResponse> Handle(DebugTestGetStartInfoRequest request)
{
var testManager = CreateTestManager(request.FileName);
_debugSessionManager.StartSession(testManager);
if (testManager.IsConnected)
{
//only if the test manager connected successfully, shall we proceed with the request
_debugSessionManager.StartSession(testManager);
return _debugSessionManager.DebugGetStartInfoAsync(request.MethodName, request.TestFrameworkName, request.TargetFrameworkVersion, CancellationToken.None);
}

return _debugSessionManager.DebugGetStartInfoAsync(request.MethodName, request.TestFrameworkName, request.TargetFrameworkVersion, CancellationToken.None);
throw new InvalidOperationException("The debugger could not be started");
}

public Task<DebugTestLaunchResponse> Handle(DebugTestLaunchRequest request)
Expand Down