Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace symbols on LSP client #1743

Closed
vamolessa opened this issue Mar 19, 2020 · 7 comments
Closed

Workspace symbols on LSP client #1743

vamolessa opened this issue Mar 19, 2020 · 7 comments
Labels

Comments

@vamolessa
Copy link

So, if you try to use omnisharp on Neovim through Coc.vim, it's not possible to list workspace symbols.
Relevant coc-omnisharp issue: coc-extensions/coc-omnisharp#14

It's strange because the feature exists on vscode (throught ctrl-t) but not on a regular lsp client it seems?

Anyone have any idea? Thanks in advance!

@razzmatazz
Copy link
Contributor

@matheuslessarodrigues vscode does not use (iirc) LSP Interface to omnisharp Server but uses a custom protocol instead

@vamolessa
Copy link
Author

oh, is that feature harder to implement with lsp? is there a workaround? or even how one could contribute with an implementation?

@razzmatazz
Copy link
Contributor

razzmatazz commented Mar 31, 2020

oh, is that feature harder to implement with lsp? is there a workaround? or even how one could contribute with an implementation?

Semantics are slightly different, and omnisharp roslyn uses an older version of https://github.com/OmniSharp/csharp-language-server-protocol/ library to plumb into LSP. I guess the job is to try and upgrade it (in omnisharp-roslyn) and see what other things need to be done to make it work with the latest changes and if all this helps.

@CyanBlob
Copy link

Is anyone working on supporting more of the LSP? The coc-omnisharp extension for Coc.vim doesn't seem to be able to jump to definition/implementation due to this project not fully supporting LSP: coc-extensions/coc-omnisharp#15

@filipw filipw added the lsp label May 8, 2020
@razzmatazz
Copy link
Contributor

razzmatazz commented May 12, 2020

@CyanBlob the library that omnisharp uses to support LSP has quite a lot of improvements done lately, but not a lot of that has yet been integrated into omnisharp, probably because it is very much still in the flux:

@razzmatazz
Copy link
Contributor

I have submited a PR #1799 that implements workspace/symbol LSP request, in particular.

@vamolessa
Copy link
Author

Oh, This is super cool! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants