AllowUnsafeBlocks=true makes all warning to error from v1.33.0

[fatfatson]

too many fake errors make real error hardly found -_-!
the earlier version doesn't have the problem.

[filipw]

can you please provide a repro example of what is not working?
Since 1.32.20 OmniSharp correctly respects TreatWarningsAsErrors so perhaps you are seeing that?

[fatfatson]

the example repo: https://github.com/fatfatson/test-omnisharp

with the code:

        static void Main(string[] args)
        {
            Console.WriteLine("Hello World!");
            return;
            Console.WriteLine("Hello Again!");
        }

a warning is reported as:

that's normal!

but if the AllowUnsafeBlocks build option is setting to true (which is neccesary for my project)

the above warning will reported as error:

I have found that from v1.33, all warnings are reported as error if AllowUnsafeBlocks=true, no matter what TreatWarningsAsErrors is set.

[filipw]

thanks a lot for the repro. I see the problem now - this is indeed a regression. Will fix this.