Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OmniSharp.exe.config should set 4.7.2 as the required framework version #1468

Closed
gregg-miskelly opened this issue Apr 17, 2019 · 0 comments · Fixed by #1469
Closed

OmniSharp.exe.config should set 4.7.2 as the required framework version #1468

gregg-miskelly opened this issue Apr 17, 2019 · 0 comments · Fixed by #1469

Comments

@gregg-miskelly
Copy link

OmniSharp now requires 4.7.2, but OmniSharp.exe.config still has the required version set to 4.6.1. This should be changed so that Windows will display the upgrade prompt instead of failing in hard to understand ways.

From c:\Users\greggm.vscode\extensions\ms-vscode.csharp-1.19.0.omnisharp\1.32.18\OmniSharp.exe.config:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <startup>
    <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.1" />
  </startup>
  <runtime>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant