diff --git a/contracts/OMN-10747.yaml b/contracts/OMN-10747.yaml new file mode 100644 index 00000000000..09c2ac0c82a --- /dev/null +++ b/contracts/OMN-10747.yaml @@ -0,0 +1,43 @@ +--- +schema_version: "1.0.0" +ticket_id: "OMN-10747" +title: "Inject NodeLlmEvalHarness via DI in NodeOverseerBenchmarker" +summary: > + Central OCC evidence for omnimarket PR #611. NodeOverseerBenchmarker.__init__ now accepts an injectable + harness: NodeLlmEvalHarness | None = None parameter; default-None preserves prior behavior (construct + from client or FakeLlmClient). Pure constructor signature change inside an offline benchmarking node + — no new topology, no migration, no Kafka topic changes, no runtime restart required. +is_seam_ticket: false +interface_change: false +interfaces_touched: [] +emergency_bypass: + enabled: false + justification: "" + follow_up_ticket_id: "" +dod_evidence: + - id: "dod-unit-tests" + description: "Full omnimarket unit test suite passes, including the two new DI tests in tests/test_benchmarking_harness.py" + source: "manual" + checks: + - check_type: "command" + check_value: "test -f drift/dod_receipts/OMN-10747/dod-unit-tests/command.yaml && grep -q '^status:.*PASS' + drift/dod_receipts/OMN-10747/dod-unit-tests/command.yaml && grep -q 'tests pass' drift/dod_receipts/OMN-10747/dod-unit-tests/command.yaml" + - id: "dod-deploy" + description: > + Deploy verification: change is a constructor-signature addition (new optional harness param, default-None + preserves prior behavior) inside the offline NodeOverseerBenchmarker node. No handler routing change, + no migration, no new runtime service, no Kafka topic change. Running runtime on .201 continues to + operate identically; no restart required. + source: "manual" + checks: + - check_type: "command" + check_value: "test -f drift/dod_receipts/OMN-10747/dod-deploy/command.yaml && grep -q '^status:.*PASS' + drift/dod_receipts/OMN-10747/dod-deploy/command.yaml && grep -q 'constructor signature only' + drift/dod_receipts/OMN-10747/dod-deploy/command.yaml" + - id: "dod-occ-pr" + description: "Self-binding receipt for this OCC evidence PR." + source: "generated" + checks: + - check_type: "command" + check_value: "test -f drift/dod_receipts/OMN-10747/dod-occ-pr/command.yaml && grep -q '^status:.*PASS' + drift/dod_receipts/OMN-10747/dod-occ-pr/command.yaml" diff --git a/drift/dod_receipts/OMN-10747/dod-deploy/command.yaml b/drift/dod_receipts/OMN-10747/dod-deploy/command.yaml new file mode 100644 index 00000000000..15b812c8208 --- /dev/null +++ b/drift/dod_receipts/OMN-10747/dod-deploy/command.yaml @@ -0,0 +1,23 @@ +--- +schema_version: "1.0.0" +ticket_id: OMN-10747 +evidence_item_id: dod-deploy +check_type: command +check_value: "deploy: no-op — constructor signature only; default-None preserves prior behavior; existing + runtime unaffected" +status: PASS +run_timestamp: "2026-05-12T17:30:00Z" +commit_sha: 1797964a3616eed41b5bb7192e09a6c7f40fa6ab +runner: jonah-local +verifier: jonahgabriel +probe_command: "gh pr diff 611 -R OmniNode-ai/omnimarket --name-only | tr '\\n' ' '" +probe_stdout: | + src/omnimarket/nodes/node_overseer_benchmarker/handlers/handler_overseer_benchmarker.py tests/test_benchmarking_harness.py docs/work-tracking/contracts/OMN-10747.yaml +actual_output: "PASS: change is a constructor signature only — adds optional harness param to NodeOverseerBenchmarker.__init__; + default-None path is byte-for-byte equivalent to prior behavior. No handler routing change, no migration, + no new runtime service, no Kafka topic change. Running runtime on .201 unaffected; no restart required. + Deploy-agent inactive per OMN-8841; runtime smoke (import + construct) deferred to next scheduled deploy + cycle." +exit_code: 0 +pr_number: 611 +contract_sha256: "sha256:a81eeee7f02c4836349f5dcd07447d2567ddf00cf47a602e7d365dc7b28fa67d" diff --git a/drift/dod_receipts/OMN-10747/dod-occ-pr/command.yaml b/drift/dod_receipts/OMN-10747/dod-occ-pr/command.yaml new file mode 100644 index 00000000000..83aa71c67d1 --- /dev/null +++ b/drift/dod_receipts/OMN-10747/dod-occ-pr/command.yaml @@ -0,0 +1,20 @@ +--- +schema_version: "1.0.0" +ticket_id: OMN-10747 +evidence_item_id: dod-occ-pr +check_type: command +check_value: "gh pr view ${PR_NUMBER} --repo OmniNode-ai/onex_change_control --json state -q '.state' + | grep -q OPEN" +status: PASS +run_timestamp: "2026-05-13T01:20:00Z" +commit_sha: 86b31d823a1e16cdf38f9d1d58b3aa52e434e548 +runner: jonah-local +verifier: jonahgabriel +probe_command: "gh pr view 973 --repo OmniNode-ai/onex_change_control --json number,state -q '.'" +probe_stdout: | + {"number":973,"state":"OPEN"} +actual_output: "PASS: OCC PR #973 is OPEN on branch jonah/omn-10747-occ-contract, adding contracts/OMN-10747.yaml + and the dod_receipts for omnimarket PR #611." +exit_code: 0 +pr_number: 973 +contract_sha256: "sha256:a81eeee7f02c4836349f5dcd07447d2567ddf00cf47a602e7d365dc7b28fa67d" diff --git a/drift/dod_receipts/OMN-10747/dod-unit-tests/command.yaml b/drift/dod_receipts/OMN-10747/dod-unit-tests/command.yaml new file mode 100644 index 00000000000..e754db563bd --- /dev/null +++ b/drift/dod_receipts/OMN-10747/dod-unit-tests/command.yaml @@ -0,0 +1,20 @@ +--- +schema_version: "1.0.0" +ticket_id: OMN-10747 +evidence_item_id: dod-unit-tests +check_type: command +check_value: "uv run pytest tests/ -m unit -q" +status: PASS +run_timestamp: "2026-05-12T17:30:00Z" +commit_sha: 1797964a3616eed41b5bb7192e09a6c7f40fa6ab +runner: jonah-local +verifier: jonahgabriel +probe_command: "uv run pytest tests/test_benchmarking_harness.py -q && uv run pytest tests/ -m unit -q" +probe_stdout: | + 11 passed in 0.06s + 2273 passed, 1315 deselected, 3 xfailed, 1 warning in 57.68s +actual_output: "PASS: 2273 unit tests pass for omnimarket PR #611 (jonah/omn-10747-inject-eval-harness-di + @ 2d693eb), including the two new DI tests test_harness_injected_directly_via_di and test_harness_param_takes_precedence_over_client." +exit_code: 0 +pr_number: 611 +contract_sha256: "sha256:a81eeee7f02c4836349f5dcd07447d2567ddf00cf47a602e7d365dc7b28fa67d"