Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component doesn't support minimum temperature below 0. #50

Open
aliceapps opened this issue Oct 11, 2022 · 7 comments
Open

Component doesn't support minimum temperature below 0. #50

aliceapps opened this issue Oct 11, 2022 · 7 comments
Labels
question Further information is requested

Comments

@aliceapps
Copy link

Component doesn't support minimum temperature below 0, but for north regions it's quite important.

@Olen
Copy link
Owner

Olen commented Oct 11, 2022

Winter is coming - good catch...

@Olen
Copy link
Owner

Olen commented Oct 11, 2022

What do you suggest is a reasonable minimum?
-10? Maybe a bit low (high?). It might trigger alerts during cold winter days.
-50? Is this a reasonable minimum? Do any plants (or even the temperature sensors) actually survive -50 for a longer period of time?
-100? According to this article, the coldes places on earth are the Eastern Antarctic Plateau (-94°C) and Vostok Station Antarctica (-89.2°C). But I don't think there are many plants living outdoors there...

@Olen Olen added the question Further information is requested label Aug 1, 2023
@ChristophCaina
Copy link
Contributor

hm... I don't know how the code handles this here - but I think, the "minimum" temperature should be, what OpenPlantBook provides for a specific plant?
If you do set the minimum temperature manually, I would just accept the input of the user, without checking if it is -10 or -50 or what ever...

Does it really need to 'validate' the input?

@Olen
Copy link
Owner

Olen commented Nov 15, 2023

An input_number requires a max and min value

https://www.home-assistant.io/integrations/input_number/

@ChristophCaina
Copy link
Contributor

hm... I would then go with +50 / -50
That should be OK in 98% of the cases ;)

@MarkAtwood
Copy link

Ordinary cheap off the shelf weather temperature sensors such as accurite and echowitt with lithium iron disulfide (so called "lithium metal') batteries like the "Energizer Ultimate Lithium" work just fine from -50°C to +60°C (I use them all the time in deep freezers and in lab ovens), which is basically "central alaska in the winter" to "death valley in july at noon" temperatures, and plants survive in those environments.

@Olen
Copy link
Owner

Olen commented Jun 22, 2024

Added a quick patch.
Max can still be 0 - 100 (guess no plants have a negative max temperature)
Min can now be -50 - +50 (guess no plants have a minimum temperature higher than +50)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants