You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As far as I am aware, only the backtick "`" (denoting inline code) and the single "$" and double "$$" dollar signs (denoting latex expressions) create this bug. When these characters are used in the alt text/image description for link embeds, the corresponding output in Anki is just the literal text of the embed instead of the image itself. From a bit of digging, I found out that it is the result of trying to match the already parsed note text to the original, unedited image embed text. I'll admit that this is a pretty strange edge-case but I'd appreciate it if this could be fixed.
The comparison is found in the format.ts file under FormatConverter.getAndFormatMedias()
Here, you get the failed comparison between "![[NOT Gate.svg|The ANSI notation for a OBSTOANKICODEINLINE gate]]" and "![[NOT Gate.svg|The ANSI notation for a NOT gate]]":
Resulting in this unexpected output:
It should be easy enough just to parse the embed.original text as well so that both are consistent with the expected value but I'm not sure if that's the best solution, seems kind of janky and a temporary patch. I would contribute any further changes myself but I'm not familiar enough with Typescript or the inner workings of the project to not break something horribly. Would it be better if a proper fix could be made further up the call stack before note_text is parsed?
Besides that, AWESOME project! I really appreciate the work you guys put in to make this entire system work. It's been invaluable to my studies. Thank you!
The text was updated successfully, but these errors were encountered:
As far as I am aware, only the backtick "`" (denoting inline code) and the single "$" and double "$$" dollar signs (denoting latex expressions) create this bug. When these characters are used in the alt text/image description for link embeds, the corresponding output in Anki is just the literal text of the embed instead of the image itself. From a bit of digging, I found out that it is the result of trying to match the already parsed note text to the original, unedited image embed text. I'll admit that this is a pretty strange edge-case but I'd appreciate it if this could be fixed.
The comparison is found in the
format.ts
file underFormatConverter.getAndFormatMedias()
Here, you get the failed comparison between "![[NOT Gate.svg|The ANSI notation for a OBSTOANKICODEINLINE gate]]" and "![[NOT Gate.svg|The ANSI notation for a
NOT
gate]]":Resulting in this unexpected output:
It should be easy enough just to parse the
embed.original
text as well so that both are consistent with the expected value but I'm not sure if that's the best solution, seems kind of janky and a temporary patch. I would contribute any further changes myself but I'm not familiar enough with Typescript or the inner workings of the project to not break something horribly. Would it be better if a proper fix could be made further up the call stack beforenote_text
is parsed?Besides that, AWESOME project! I really appreciate the work you guys put in to make this entire system work. It's been invaluable to my studies. Thank you!
The text was updated successfully, but these errors were encountered: