Skip to content

fix: replace focus:outline-hidden with visible focus styles for accessibility#3989

Closed
nazimmuhammed wants to merge 6 commits intoOWASP:mainfrom
nazimmuhammed:main
Closed

fix: replace focus:outline-hidden with visible focus styles for accessibility#3989
nazimmuhammed wants to merge 6 commits intoOWASP:mainfrom
nazimmuhammed:main

Conversation

@nazimmuhammed
Copy link
Contributor

Improved accessibility by replacing focus:outline-hidden with visible focus styles using focus-visible:outline.

This ensures keyboard users can clearly see focus state.

Closes #3988

@github-actions github-actions bot added docs Improvements or additions to documentation frontend labels Feb 18, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • Documentation

    • Updated security policy with vulnerability reporting guidelines, response timelines, and supported versions information.
  • Style

    • Improved keyboard focus indicator styling for footer buttons.

Walkthrough

Security policy documentation added with structured vulnerability reporting procedures. Jest ResizeObserver mock implementation refactored from empty methods to Jest mock fields. Footer button focus styling updated to use focus-visible classes for improved keyboard accessibility.

Changes

Cohort / File(s) Summary
Documentation
SECURITY.md
Added "Supported Versions", "Reporting a Vulnerability", "What to Include", "How to Report", and "Response Timeline" sections detailing security reporting workflow, timelines for acknowledgment and investigation, and disclosure procedures.
Test Setup
frontend/jest.setup.ts
Refactored ResizeObserver mock: changed disconnect(), observe(), and unobserve() from empty method declarations to public fields initialized with jest.fn() for improved mock call tracking.
Frontend Components
frontend/src/components/Footer.tsx
Updated Button focus styling from focus:outline-hidden to focus-visible:outline variants (focus-visible:outline, focus-visible:outline-2, focus-visible:outline-slate-500) for enhanced keyboard accessibility.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

frontend, frontend-tests, docs

Suggested reviewers

  • arkid15r
  • kasya
✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

The linked issue must be assigned to the PR author.

@github-actions github-actions bot closed this Feb 18, 2026
@sonarqubecloud
Copy link

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve footer button accessibility focus visibility

2 participants

Comments