Skip to content

Improved accessibility by replacing focus:outline-hidden with visible focus styles using focus-visible:outline. This ensures keyboard users can clearly see focus state. Closes #3988 #3986

Closed
nazimmuhammed wants to merge 6 commits intoOWASP:mainfrom
nazimmuhammed:main

Conversation

@nazimmuhammed
Copy link
Contributor

Description

Improved accessibility by replacing focus:outline-hidden with visible focus styles using focus-visible:outline.

This ensures keyboard users can clearly see focus state.

Type of change

  • Accessibility improvement
  • UI improvement

Checklist

  • Tested locally
  • No breaking changes

@github-actions github-actions bot added docs Improvements or additions to documentation frontend labels Feb 18, 2026
@github-actions
Copy link

PR validation failed: No linked issue and no valid closing issue reference in PR description

@github-actions github-actions bot closed this Feb 18, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • Documentation

    • Added a comprehensive security policy including supported versions, vulnerability reporting guidelines, and response timelines.
  • Style

    • Updated button focus outline styling for improved keyboard navigation visibility.

Walkthrough

The PR adds comprehensive security vulnerability reporting guidelines to the documentation, refactors Jest ResizeObserver mocks to use jest.fn() properties for better test spy capability, and updates keyboard focus styling in the Footer component to use explicit focus-visible pseudo-class styles.

Changes

Cohort / File(s) Summary
Security Documentation
SECURITY.md
Added "Supported Versions," "Vulnerability Reporting" sections with reporting form guidance, "What to Include" checklist for reports, and "Response Timeline" for vulnerability disclosure process.
Test Configuration
frontend/jest.setup.ts
Replaced ResizeObserver mock method implementations with jest.fn() properties (disconnect, observe, unobserve) to enable spy/assertion capabilities on mock calls.
Component Styling
frontend/src/components/Footer.tsx
Updated Button className focus styles from focus:outline-hidden to explicit focus-visible states (focus-visible:outline, focus-visible:outline-2, focus-visible:outline-slate-500) for keyboard accessibility.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

frontend, frontend-tests, docs

Suggested reviewers

  • kasya
  • arkid15r
✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@nazimmuhammed nazimmuhammed changed the title fix: improve footer button accessibility focus visibility Improved accessibility by replacing focus:outline-hidden with visible focus styles using focus-visible:outline. This ensures keyboard users can clearly see focus state. Closes #3988 Feb 18, 2026
@nazimmuhammed nazimmuhammed changed the title Improved accessibility by replacing focus:outline-hidden with visible focus styles using focus-visible:outline. This ensures keyboard users can clearly see focus state. Closes #3988 Improved accessibility by replacing focus:outline-hidden with visible focus styles using focus-visible:outline. This ensures keyboard users can clearly see focus state. Feb 18, 2026
@nazimmuhammed nazimmuhammed changed the title Improved accessibility by replacing focus:outline-hidden with visible focus styles using focus-visible:outline. This ensures keyboard users can clearly see focus state. Improved accessibility by replacing focus:outline-hidden with visible focus styles using focus-visible:outline. This ensures keyboard users can clearly see focus state. closes Feb 18, 2026
@nazimmuhammed nazimmuhammed changed the title Improved accessibility by replacing focus:outline-hidden with visible focus styles using focus-visible:outline. This ensures keyboard users can clearly see focus state. closes Improved accessibility by replacing focus:outline-hidden with visible focus styles using focus-visible:outline. This ensures keyboard users can clearly see focus state. Closes #3988 Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments