diff --git a/frontend/__tests__/e2e/pages/Home.spec.ts b/frontend/__tests__/e2e/pages/Home.spec.ts index 635b7a1fa0..4f5aa5ffd9 100644 --- a/frontend/__tests__/e2e/pages/Home.spec.ts +++ b/frontend/__tests__/e2e/pages/Home.spec.ts @@ -50,9 +50,8 @@ test.describe('Home Page', () => { test('should have top contributors', async ({ page }) => { await expect(page.getByRole('heading', { name: 'Top Contributors' })).toBeVisible() await expect(page.getByRole('img', { name: 'Contributor 1' })).toBeVisible() - await expect(page.getByRole('link', { name: 'Project 21' })).toBeVisible() - await page.getByText('Contributor 1').click() - expect(page.url()).toContain('community/users/contributor1') + await expect(page.getByText('Contributor 1')).toBeVisible() + await expect(page.getByText('Project 21')).toBeVisible() }) test('should have recent issues', async ({ page }) => { diff --git a/frontend/__tests__/unit/pages/ChapterDetails.test.tsx b/frontend/__tests__/unit/pages/ChapterDetails.test.tsx index f79b9e6138..4a24f36110 100644 --- a/frontend/__tests__/unit/pages/ChapterDetails.test.tsx +++ b/frontend/__tests__/unit/pages/ChapterDetails.test.tsx @@ -87,7 +87,7 @@ describe('chapterDetailsPage Component', () => { ...mockChapterDetailsData, topContributors: [ { - name: 'user1', + name: 'Contributor 1', avatarUrl: 'https://example.com/avatar1.jpg', contributionsCount: 30, }, @@ -100,7 +100,7 @@ describe('chapterDetailsPage Component', () => { render() await waitFor(() => { - expect(screen.getByText('user1')).toBeInTheDocument() + expect(screen.getByText('Contributor 1')).toBeInTheDocument() }) }) }) diff --git a/frontend/__tests__/unit/pages/CommitteeDetails.test.tsx b/frontend/__tests__/unit/pages/CommitteeDetails.test.tsx index 5b078febaf..568ea860df 100644 --- a/frontend/__tests__/unit/pages/CommitteeDetails.test.tsx +++ b/frontend/__tests__/unit/pages/CommitteeDetails.test.tsx @@ -80,7 +80,7 @@ describe('CommitteeDetailsPage Component', () => { { avatarUrl: 'https://example.com/avatar1.jpg', contributionsCount: 30, - login: 'user1', + login: 'Contributor 1', name: '', __typename: 'UserNode', }, @@ -94,7 +94,7 @@ describe('CommitteeDetailsPage Component', () => { render() await waitFor(() => { - expect(screen.getByText('user1')).toBeInTheDocument() + expect(screen.getByText('Contributor 1')).toBeInTheDocument() }) }) diff --git a/frontend/src/components/CardDetailsPage.tsx b/frontend/src/components/CardDetailsPage.tsx index d62266fc2e..12db7c84ee 100644 --- a/frontend/src/components/CardDetailsPage.tsx +++ b/frontend/src/components/CardDetailsPage.tsx @@ -87,7 +87,7 @@ const DetailsCard = ({ {topics.length !== 0 && } )} - + {(type === 'project' || type === 'repository') && (
{ const navigate = useNavigate() const [showAllContributors, setShowAllContributors] = useState(false) @@ -30,44 +34,31 @@ const TopContributors = ({ return (

{label}

-
- {displayContributors.map((contributor, index) => ( -
+ {displayContributors.map((item, index) => ( + - - {contributor?.projectName ? ( -

- - {contributor.projectName} - -

- ) : ( -

- {contributor?.contributionsCount} contributions -

- )} +
+
+ {item?.name} +

+ {capitalize(item.name) || capitalize(item.login)} +

+
+
+
+ + {type === 'contributor' + ? `${item.contributionsCount ?? 0} contributions` + : item.projectName} + +
+
-
+ ))}
{contributors.length > maxInitialDisplay && ( diff --git a/frontend/src/pages/Home.tsx b/frontend/src/pages/Home.tsx index 60a4ba9698..577d2aef3c 100644 --- a/frontend/src/pages/Home.tsx +++ b/frontend/src/pages/Home.tsx @@ -249,7 +249,7 @@ export default function Home() { }} />
- +