Skip to content

Commit f01f21e

Browse files
committed
Add suggestions
1 parent 7b3677a commit f01f21e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

backend/apps/github/admin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class PullRequestAdmin(admin.ModelAdmin):
4444

4545
def custom_field_github_url(self, obj):
4646
"""Pull Request GitHub URL."""
47-
return mark_safe(f"<a href='{obj.url}' target='_blank'>↗️</a>") # noqa: S308
47+
return mark_safe(f"<a href='{obj.url}' target='_blank' rel='noopener noreferrer'>↗️</a>")
4848

4949
custom_field_github_url.short_description = "GitHub 🔗"
5050

@@ -69,7 +69,7 @@ class IssueAdmin(admin.ModelAdmin):
6969

7070
def custom_field_github_url(self, obj):
7171
"""Issue GitHub URL."""
72-
return mark_safe(f"<a href='{obj.url}' target='_blank'>↗️</a>") # noqa: S308
72+
return mark_safe(f"<a href='{obj.url}' target='_blank' rel='noopener noreferrer'>↗️</a>")
7373

7474
custom_field_github_url.short_description = "GitHub 🔗"
7575

backend/apps/github/models/pull_request.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class Meta:
5252
)
5353

5454
def from_github(self, gh_pull_request, author=None, repository=None):
55-
"""Update instance based on GitHub issue data."""
55+
"""Update instance based on GitHub pull request data."""
5656
field_mapping = {
5757
"body": "body",
5858
"closed_at": "closed_at",
@@ -84,7 +84,7 @@ def save(self, *args, **kwargs):
8484

8585
@staticmethod
8686
def bulk_save(pull_requests, fields=None):
87-
"""Bulk save issues."""
87+
"""Bulk save pull requests."""
8888
BulkSaveModel.bulk_save(PullRequest, pull_requests, fields=fields)
8989

9090
@staticmethod

backend/apps/github/models/repository.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def latest_updated_issue(self):
118118

119119
@property
120120
def latest_updated_pull_request(self):
121-
"""Repository latest updated pull request."""
121+
"""Repository latest updated pull request (most recently modified)."""
122122
return self.pull_requests.order_by("-updated_at").first()
123123

124124
@property

0 commit comments

Comments
 (0)