Skip to content

Commit bbf0b27

Browse files
committed
Update tests and queries
1 parent 1cd6b1a commit bbf0b27

File tree

4 files changed

+54
-19
lines changed

4 files changed

+54
-19
lines changed

backend/apps/owasp/graphql/nodes/project_health_metrics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"contributors_count",
1313
"forks_count",
1414
"is_funding_requirements_compliant",
15-
"is_project_leaders_requirements_compliant",
15+
"is_leader_requirements_compliant",
1616
"open_issues_count",
1717
"recent_releases_count",
1818
"score",

backend/apps/owasp/graphql/queries/project_health_metrics.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ def unhealthy_projects(
1818
self,
1919
*,
2020
is_contributors_requirement_compliant: bool | None = None,
21-
is_funding_requirement_compliant: bool | None = None,
21+
is_funding_requirements_compliant: bool | None = None,
2222
has_recent_commits: bool | None = None,
2323
has_recent_releases: bool | None = None,
24-
is_leaders_requirement_compliant: bool | None = None,
24+
is_leader_requirements_compliant: bool | None = None,
2525
limit: int = 20,
2626
has_long_open_issues: bool | None = None,
2727
has_long_unanswered_issues: bool | None = None,
@@ -59,11 +59,11 @@ def unhealthy_projects(
5959
if has_long_unassigned_issues is not None:
6060
filters["has_long_unassigned_issues"] = has_long_unassigned_issues
6161

62-
if is_leaders_requirement_compliant is not None:
63-
filters["is_project_leaders_requirements_compliant"] = is_leaders_requirement_compliant
62+
if is_leader_requirements_compliant is not None:
63+
filters["is_leader_requirements_compliant"] = is_leader_requirements_compliant
6464

65-
if is_funding_requirement_compliant is not None:
66-
filters["is_funding_requirements_compliant"] = is_funding_requirement_compliant
65+
if is_funding_requirements_compliant is not None:
66+
filters["is_funding_requirements_compliant"] = is_funding_requirements_compliant
6767

6868
if has_low_score:
6969
filters["score__lt"] = 50

backend/tests/apps/owasp/graphql/nodes/project_health_metrics_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def test_meta_configuration(self):
1818
"contributors_count",
1919
"forks_count",
2020
"is_funding_requirements_compliant",
21-
"is_project_leaders_requirements_compliant",
21+
"is_leader_requirements_compliant",
2222
"last_commit_days",
2323
"last_pull_request_days",
2424
"last_release_days",
@@ -50,7 +50,7 @@ def _get_field_by_name(self, name):
5050
("contributors_count", int),
5151
("forks_count", int),
5252
("is_funding_requirements_compliant", bool),
53-
("is_project_leaders_requirements_compliant", bool),
53+
("is_leader_requirements_compliant", bool),
5454
("last_commit_days", int),
5555
("last_pull_request_days", int),
5656
("last_release_days", int),

backend/tests/apps/owasp/graphql/queries/project_health_metrics_test.py

Lines changed: 45 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,16 @@ def test_unhealthy_projects_field_configuration(self):
3030

3131
arg_names = [arg.python_name for arg in unhealthy_projects_field.arguments]
3232
expected_arg_names = [
33-
"contributors_count_requirement_compliant",
34-
"funding_requirement_compliant",
35-
"no_recent_commits",
36-
"no_recent_releases",
37-
"leaders_requirement_compliant",
33+
"is_contributors_requirement_compliant",
34+
"is_funding_requirements_compliant",
35+
"has_recent_commits",
36+
"has_recent_releases",
37+
"is_leader_requirements_compliant",
3838
"limit",
39-
"long_open_issues",
40-
"long_unanswered_issues",
41-
"long_unassigned_issues",
42-
"low_score",
39+
"has_long_open_issues",
40+
"has_long_unanswered_issues",
41+
"has_long_unassigned_issues",
42+
"has_low_score",
4343
]
4444
assert set(arg_names) == set(expected_arg_names)
4545

@@ -55,7 +55,7 @@ def _setup(self):
5555
self.mocked_objects = mocked_objects
5656
yield
5757

58-
def test_resolve_unhealthy_projects(self):
58+
def test_resolve_unhealthy_projects_without_filters(self):
5959
"""Test the resolution of unhealthy projects."""
6060
# Mock the queryset
6161
mock_queryset = Mock()
@@ -77,3 +77,38 @@ def test_resolve_unhealthy_projects(self):
7777

7878
assert isinstance(result, list)
7979
mock_filter.select_related.assert_called_with("project")
80+
81+
# def test_resolve_unhealthy_projects_with_filters(self):
82+
# """Test the resolution of unhealthy projects with filters."""
83+
# # Mock the queryset
84+
# mock_queryset = Mock()
85+
# self.mocked_objects.select_related.return_value = mock_queryset
86+
# mock_queryset.order_by.return_value.distinct.return_value = mock_queryset
87+
# # Filters
88+
# mock_filter = Mock()
89+
# mock_queryset.filter.return_value = mock_filter
90+
# mock_filter.select_related.return_value = [mock_filter]
91+
92+
# # Create an instance of the query class
93+
# query_instance = ProjectHealthMetricsQuery()
94+
95+
# # Call the method with filters
96+
# result = query_instance.unhealthy_projects(
97+
# is_contributors_requirement_compliant=True,
98+
# is_funding_requirements_compliant=False,
99+
# has_recent_commits=True,
100+
# has_recent_releases=False,
101+
# is_leaders_requirement_compliant=True,
102+
# limit=10,
103+
# has_long_open_issues=False,
104+
# has_long_unanswered_issues=True,
105+
# has_long_unassigned_issues=False,
106+
# has_low_score=True,
107+
# )
108+
109+
# # Assert that the mocked queryset was called correctly with filters
110+
# self.mocked_objects.select_related.assert_called_with("project")
111+
# mock_queryset.order_by.assert_called_with("project__key", "-nest_created_at")
112+
113+
# assert isinstance(result, list)
114+
# mock_filter.select_related.assert_called_with("project")

0 commit comments

Comments
 (0)