test: Refactor archived badge tests for consistency and clarity in RepositoryNode, CardDetailsPage, and RepositoriesCard components

Author: mrkeshav-05

backend/tests/apps/github/api/internal/nodes/repository_test.py

@@ -207,20 +207,22 @@ def test_url_method(self):
     def test_is_archived_field_exists(self):
         """Test that is_archived field is exposed in the GraphQL schema."""
         field_names = {field.name for field in RepositoryNode.__strawberry_definition__.fields}
-        assert "is_archived" in field_names, "is_archived field should be exposed in RepositoryNode"
+        assert "is_archived" in field_names, (
+            "is_archived field should be exposed in RepositoryNode"
+        )
 
     def test_is_archived_field_returns_true(self):
         """Test is_archived field returns True for archived repositories."""
         mock_repository = Mock()
         mock_repository.is_archived = True
-        
+
         # Since is_archived is a direct field mapping, we just verify the mock
         assert mock_repository.is_archived is True
 
     def test_is_archived_field_returns_false(self):
         """Test is_archived field returns False for non-archived repositories."""
         mock_repository = Mock()
         mock_repository.is_archived = False
-        
+
         # Since is_archived is a direct field mapping, we just verify the mock
         assert mock_repository.is_archived is False

frontend/__tests__/unit/components/ArchivedBadge.test.tsx

@@ -1,10 +1,8 @@
-import { faArchive } from '@fortawesome/free-solid-svg-icons'
 import { render, screen } from '@testing-library/react'
-import React from 'react'
 import ArchivedBadge from 'components/ArchivedBadge'
 
 jest.mock('@fortawesome/react-fontawesome', () => ({
-  FontAwesomeIcon: ({ icon, className }: { icon: any; className: string }) => (
+  FontAwesomeIcon: ({ className }: { className: string }) => (
     <i data-testid="archive-icon" className={className} />
   ),
 }))
@@ -13,53 +11,50 @@ describe('ArchivedBadge', () => {
   describe('Basic Rendering', () => {
     it('renders successfully with default props', () => {
       render(<ArchivedBadge />)
-      
+
       expect(screen.getByText('Archived')).toBeInTheDocument()
     })
 
     it('displays the archived text', () => {
       render(<ArchivedBadge />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toBeVisible()
     })
 
     it('has the correct tooltip', () => {
       render(<ArchivedBadge />)
-      
+
       const badge = screen.getByText('Archived')
-      expect(badge).toHaveAttribute(
-        'title',
-        'This repository has been archived and is read-only'
-      )
+      expect(badge).toHaveAttribute('title', 'This repository has been archived and is read-only')
     })
   })
 
   describe('Size Variants', () => {
     it('renders with small size', () => {
       render(<ArchivedBadge size="sm" />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toHaveClass('px-2', 'py-1', 'text-xs')
     })
 
     it('renders with medium size (default)', () => {
       render(<ArchivedBadge size="md" />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toHaveClass('px-3', 'py-1', 'text-sm')
     })
 
     it('renders with large size', () => {
       render(<ArchivedBadge size="lg" />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toHaveClass('px-4', 'py-2', 'text-base')
     })
 
     it('defaults to medium size when size prop is not provided', () => {
       render(<ArchivedBadge />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toHaveClass('px-3', 'py-1', 'text-sm')
     })
@@ -68,28 +63,28 @@ describe('ArchivedBadge', () => {
   describe('Icon Display', () => {
     it('shows icon by default', () => {
       render(<ArchivedBadge />)
-      
+
       const icon = screen.getByTestId('archive-icon')
       expect(icon).toBeInTheDocument()
     })
 
     it('shows icon when showIcon is true', () => {
       render(<ArchivedBadge showIcon={true} />)
-      
+
       const icon = screen.getByTestId('archive-icon')
       expect(icon).toBeInTheDocument()
     })
 
     it('hides icon when showIcon is false', () => {
       render(<ArchivedBadge showIcon={false} />)
-      
+
       const icon = screen.queryByTestId('archive-icon')
       expect(icon).not.toBeInTheDocument()
     })
 
     it('applies correct icon class', () => {
       render(<ArchivedBadge />)
-      
+
       const icon = screen.getByTestId('archive-icon')
       expect(icon).toHaveClass('h-3', 'w-3')
     })
@@ -98,31 +93,21 @@ describe('ArchivedBadge', () => {
   describe('Styling', () => {
     it('has correct base styling classes', () => {
       render(<ArchivedBadge />)
-      
+
       const badge = screen.getByText('Archived')
-      expect(badge).toHaveClass(
-        'inline-flex',
-        'items-center',
-        'gap-1.5',
-        'rounded-full',
-        'border'
-      )
+      expect(badge).toHaveClass('inline-flex', 'items-center', 'gap-1.5', 'rounded-full', 'border')
     })
 
     it('has correct light mode color classes', () => {
       render(<ArchivedBadge />)
-      
+
       const badge = screen.getByText('Archived')
-      expect(badge).toHaveClass(
-        'border-yellow-600',
-        'bg-yellow-50',
-        'text-yellow-800'
-      )
+      expect(badge).toHaveClass('border-yellow-600', 'bg-yellow-50', 'text-yellow-800')
     })
 
     it('has correct dark mode color classes', () => {
       render(<ArchivedBadge />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toHaveClass(
         'dark:border-yellow-500',
@@ -133,7 +118,7 @@ describe('ArchivedBadge', () => {
 
     it('has font-medium class', () => {
       render(<ArchivedBadge />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toHaveClass('font-medium')
     })
@@ -142,21 +127,21 @@ describe('ArchivedBadge', () => {
   describe('Custom ClassName', () => {
     it('applies custom className', () => {
       render(<ArchivedBadge className="custom-class" />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toHaveClass('custom-class')
     })
 
     it('preserves default classes with custom className', () => {
       render(<ArchivedBadge className="ml-2" />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toHaveClass('ml-2', 'inline-flex', 'rounded-full')
     })
 
     it('handles empty custom className', () => {
       render(<ArchivedBadge className="" />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toBeInTheDocument()
     })
@@ -165,14 +150,14 @@ describe('ArchivedBadge', () => {
   describe('Accessibility', () => {
     it('renders as a span element', () => {
       render(<ArchivedBadge />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge.tagName).toBe('SPAN')
     })
 
     it('has descriptive tooltip for screen readers', () => {
       render(<ArchivedBadge />)
-      
+
       const badge = screen.getByText('Archived')
       const title = badge.getAttribute('title')
       expect(title).toBeTruthy()
@@ -182,22 +167,16 @@ describe('ArchivedBadge', () => {
 
     it('has appropriate semantic structure with icon', () => {
       render(<ArchivedBadge />)
-      
+
       const badge = screen.getByText('Archived')
       expect(badge).toContainHTML('i')
     })
   })
 
   describe('Edge Cases', () => {
     it('handles all props together', () => {
-      render(
-        <ArchivedBadge
-          size="lg"
-          showIcon={false}
-          className="extra-margin"
-        />
-      )
-      
+      render(<ArchivedBadge size="lg" showIcon={false} className="extra-margin" />)
+
       const badge = screen.getByText('Archived')
       expect(badge).toBeInTheDocument()
       expect(badge).toHaveClass('px-4', 'py-2', 'text-base', 'extra-margin')
@@ -206,18 +185,18 @@ describe('ArchivedBadge', () => {
 
     it('renders consistently across multiple instances', () => {
       const { rerender } = render(<ArchivedBadge />)
-      
+
       const firstRender = screen.getByText('Archived').className
-      
+
       rerender(<ArchivedBadge />)
-      
+
       const secondRender = screen.getByText('Archived').className
       expect(firstRender).toBe(secondRender)
     })
 
     it('does not render any interactive elements', () => {
       const { container } = render(<ArchivedBadge />)
-      
+
       expect(container.querySelector('button')).not.toBeInTheDocument()
       expect(container.querySelector('a')).not.toBeInTheDocument()
       expect(container.querySelector('input')).not.toBeInTheDocument()

frontend/__tests__/unit/components/CardDetailsPage.test.tsx

@@ -1467,14 +1467,6 @@ describe('CardDetailsPage', () => {
     })
 
     it('archived badge renders with medium size', () => {
-      const archivedProps = {
-        ...defaultProps,
-        type: 'repository',
-        isArchived: true,
-      }
-
-      const { container } = render(<CardDetailsPage {...archivedProps} />)
-
       const badge = screen.getByText('Archived')
       expect(badge).toHaveClass('px-3', 'py-1', 'text-sm')
     })
@@ -1483,7 +1475,7 @@ describe('CardDetailsPage', () => {
       const nullArchivedProps = {
         ...defaultProps,
         type: 'repository',
-        isArchived: null as any,
+        isArchived: null,
       }
 
       render(<CardDetailsPage {...nullArchivedProps} />)

frontend/__tests__/unit/components/RepositoriesCard.test.tsx

@@ -225,25 +225,11 @@ describe('RepositoriesCard', () => {
     })
 
     it('archived badge has small size on cards', () => {
-      const archivedRepo: RepositoryCardProps = {
-        ...createMockRepository(0),
-        isArchived: true,
-      }
-
-      const { container } = render(<RepositoriesCard repositories={[archivedRepo]} />)
-
       const badge = screen.getByText('Archived')
       expect(badge).toHaveClass('px-2', 'py-1', 'text-xs')
     })
 
     it('archived badge does not show icon on cards', () => {
-      const archivedRepo: RepositoryCardProps = {
-        ...createMockRepository(0),
-        isArchived: true,
-      }
-
-      const { container } = render(<RepositoriesCard repositories={[archivedRepo]} />)
-
       const badge = screen.getByText('Archived')
       const icon = badge.querySelector('[data-testid="archive-icon"]')
       expect(icon).not.toBeInTheDocument()
@@ -278,7 +264,7 @@ describe('RepositoriesCard', () => {
     it('handles null isArchived gracefully', () => {
       const repo: RepositoryCardProps = {
         ...createMockRepository(0),
-        isArchived: null as any,
+        isArchived: null,
       }
 
       render(<RepositoriesCard repositories={[repo]} />)