Skip to content

Commit 7301ccc

Browse files
committed
Update code
1 parent 875356e commit 7301ccc

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

backend/apps/owasp/api/internal/views/project_health_metrics.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@
1111
@require_GET
1212
def generate_overview_pdf(_request):
1313
"""Generate a PDF overview of OWASP project health metrics."""
14-
pdf = ProjectHealthMetrics.generate_overview_pdf()
1514
return FileResponse(
16-
pdf,
15+
ProjectHealthMetrics.generate_overview_pdf(),
1716
as_attachment=True,
1817
filename="owasp_project_health_metrics_overview.pdf",
1918
)
@@ -25,9 +24,11 @@ def generate_project_health_metrics_pdf(_request, project_key: str):
2524
if not re.match(r"^[a-zA-Z0-9_-]+$", project_key):
2625
return HttpResponseBadRequest("Invalid project key")
2726

28-
pdf = ProjectHealthMetrics.generate_latest_metrics_pdf(project_key)
29-
if not pdf:
30-
return HttpResponseNotFound("No health metrics found for project")
31-
return FileResponse(
32-
pdf, as_attachment=True, filename=f"{project_key}_health_metrics_report.pdf"
33-
)
27+
if pdf := ProjectHealthMetrics.generate_latest_metrics_pdf(project_key):
28+
return FileResponse(
29+
pdf,
30+
as_attachment=True,
31+
filename=f"{project_key}_health_metrics_report.pdf",
32+
)
33+
34+
return HttpResponseNotFound("No health metrics found for this project")

frontend/src/app/projects/dashboard/metrics/[projectKey]/page.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import LineChart from 'components/LineChart'
2323
import LoadingSpinner from 'components/LoadingSpinner'
2424
import MetricsPDFButton from 'components/MetricsPDFButton'
2525
import MetricsScoreCircle from 'components/MetricsScoreCircle'
26+
2627
const ProjectHealthMetricsDetails: FC = () => {
2728
const { projectKey } = useParams()
2829
const [metricsList, setMetricsList] = useState<HealthMetricsProps[]>()

0 commit comments

Comments
 (0)