Skip to content

Commit 2106bd4

Browse files
committed
refactor(admin): update docstrings in backend/apps per review
1 parent 7abf90f commit 2106bd4

File tree

8 files changed

+8
-90
lines changed

8 files changed

+8
-90
lines changed

backend/apps/owasp/admin/entity_channel.py

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
@admin.action(description="Mark selected EntityChannels as reviewed")
1111
def mark_as_reviewed(_modeladmin, request, queryset):
12-
"""Mark selected EntityChannel records as reviewed."""
12+
"""Mark selected EntityChannel records as reviewed."""
1313
messages.success(
1414
request,
1515
f"Marked {queryset.update(is_reviewed=True)} EntityChannel(s) as reviewed.",
@@ -62,8 +62,7 @@ class EntityChannelAdmin(admin.ModelAdmin):
6262
)
6363

6464
def channel_search_display(self, obj):
65-
"""Return the display name of the related channel for admin lists."""
66-
65+
"""Return a readable channel label for admin display."""
6766
if obj.channel_id and obj.channel_type:
6867
try:
6968
if obj.channel_type.model == "conversation":
@@ -72,24 +71,10 @@ def channel_search_display(self, obj):
7271
except Conversation.DoesNotExist:
7372
return f"Channel {obj.channel_id} (not found)"
7473
return "-"
75-
7674
channel_search_display.short_description = "Channel Name"
7775

7876
def get_form(self, request, obj=None, **kwargs):
79-
"""
80-
Return the ModelForm class used by the admin for EntityChannel.
81-
82-
This method also attaches `conversation_content_type_id` to the form
83-
class so the admin form can reference the ContentType id for the
84-
Conversation model (used client-side or in template logic).
85-
86-
Args:
87-
request (HttpRequest): The current request.
88-
obj (EntityChannel | None): The instance being edited (or None for add).
89-
90-
Returns:
91-
Type[ModelForm]: The form class used by this admin.
92-
"""
77+
"""Return the admin form with Conversation content type metadata attached."""
9378
form = super().get_form(request, obj, **kwargs)
9479
form.conversation_content_type_id = ContentType.objects.get_for_model(Conversation).id
9580

backend/apps/owasp/admin/entity_member.py

Lines changed: 3 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,7 @@
1313

1414

1515
class EntityMemberAdmin(admin.ModelAdmin):
16-
"""
17-
Admin configuration for EntityMember records.
18-
19-
EntityMember links a person (Member) to any OWASP entity such as
20-
Projects, Chapters, or Committees.
21-
"""
16+
"""Admin configuration for EntityMember records. """
2217

2318
actions = ("approve_members",)
2419
autocomplete_fields = ("member",)
@@ -52,13 +47,7 @@ def approve_members(self, request, queryset):
5247
5348
Sets `is_active=True` and `is_reviewed=True` on all selected records
5449
and displays a success message showing how many were updated.
55-
56-
Args:
57-
request (HttpRequest): The current request.
58-
queryset (QuerySet[EntityMember]): The selected members to approve.
59-
60-
Returns:
61-
None
50+
6251
"""
6352
self.message_user(
6453
request,
@@ -71,12 +60,6 @@ def entity(self, obj):
7160
Return a clickable admin link to the related entity.
7261
7362
Example output: a link to the Project/Chapter/Committee admin change page.
74-
75-
Args:
76-
obj (EntityMember): The EntityMember instance.
77-
78-
Returns:
79-
str: HTML anchor tag or '-' if no entity is assigned.
8063
"""
8164
return (
8265
format_html(
@@ -95,12 +78,7 @@ def entity(self, obj):
9578
def owasp_url(self, obj):
9679
"""
9780
Return a link to the OWASP site page of the linked entity.
98-
99-
Args:
100-
obj (EntityMember): The EntityMember instance.
101-
102-
Returns:
103-
str: HTML anchor tag linking to the entity’s OWASP page, or '-'.
81+
10482
"""
10583
return (
10684
format_html('<a href="{}" target="_blank">↗️</a>', obj.entity.owasp_url)
@@ -118,14 +96,6 @@ def get_search_results(self, request, queryset, search_term):
11896
- Committee name or key
11997
12098
and includes matching EntityMember rows in the results.
121-
122-
Args:
123-
request (HttpRequest): The current request.
124-
queryset (QuerySet): Initial queryset.
125-
search_term (str): The text entered in the search field.
126-
127-
Returns:
128-
tuple[QuerySet, bool]: Updated queryset and distinct flag.
12999
"""
130100
queryset, use_distinct = super().get_search_results(request, queryset, search_term)
131101

backend/apps/owasp/admin/member_profile.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,6 @@ def get_queryset(self, request):
7878
This override applies `select_related("github_user")` to reduce the
7979
number of SQL queries when displaying MemberProfile entries that include
8080
related GitHub user information.
81-
82-
Args:
83-
request (HttpRequest): The current admin request.
84-
85-
Returns:
86-
QuerySet[MemberProfile]: The optimized queryset with related user data.
8781
"""
8882
queryset = super().get_queryset(request)
8983
return queryset.select_related("github_user")

backend/apps/owasp/admin/member_snapshot.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,6 @@ def get_queryset(self, request):
114114
Adds `select_related("github_user")` to reduce SQL queries by fetching
115115
related GitHub user data in a single query. This improves performance
116116
when displaying snapshots with user information.
117-
118-
Args:
119-
request (HttpRequest): The current admin request.
120-
121-
Returns:
122-
QuerySet[MemberSnapshot]: Optimized queryset with related user data.
123117
"""
124118
queryset = super().get_queryset(request)
125119
return queryset.select_related("github_user")

backend/apps/owasp/admin/mixins.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -232,14 +232,6 @@ def get_common_config(
232232
):
233233
"""
234234
Build a dictionary of common ModelAdmin configuration values.
235-
236-
Args:
237-
extra_list_display (iterable[str] | None): Additional list_display fields.
238-
extra_search_fields (iterable[str] | None): Additional search_fields.
239-
extra_list_filters (iterable[str] | None): Additional list_filter fields.
240-
241-
Returns:
242-
dict: A dictionary suitable for unpacking into a ModelAdmin definition.
243235
"""
244236
config = {}
245237

backend/apps/owasp/admin/project.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,6 @@ def custom_field_name(self, obj) -> str:
6060
If the project has a defined `name`, it is shown; otherwise the project
6161
key is used as a fallback. This ensures that every project row has a
6262
readable identifier even when optional fields are empty.
63-
64-
Args:
65-
obj (Project): The project instance.
66-
67-
Returns:
68-
str: The readable project label.
6963
"""
7064
return f"{obj.name or obj.key}"
7165

backend/apps/owasp/admin/project_health_metrics.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,7 @@ def project(self, obj):
3434
3535
Used in the admin list view to show a readable project label instead
3636
of the raw project foreign key reference.
37-
38-
Args:
39-
obj (ProjectHealthMetrics): The metrics instance.
40-
41-
Returns:
42-
str: The project name, or "N/A" if no project is assigned.
37+
4338
"""
4439
return obj.project.name if obj.project else "N/A"
4540

backend/apps/slack/admin/member.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,7 @@ def approve_suggested_users(self, request, queryset):
3131
- If exactly one suggested user exists, it is assigned to the Member.
3232
- If multiple suggested users exist, an error message is returned because only one can be assigned.
3333
- If none exist, a warning message is shown.
34-
35-
Args:
36-
request (HttpRequest): The current HTTP request.
37-
queryset (QuerySet[Member]): The selected Member objects.
38-
39-
Returns:
40-
None
34+
4135
"""
4236
for entity in queryset:
4337
suggestions = entity.suggested_users.all()

0 commit comments

Comments
 (0)