Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate resources section for leaders and followers for redis-cluster chart #1186

Open
AharonIsraelCohen opened this issue Dec 23, 2024 · 3 comments · May be fixed by #1188
Open

Separate resources section for leaders and followers for redis-cluster chart #1186

AharonIsraelCohen opened this issue Dec 23, 2024 · 3 comments · May be fixed by #1188
Assignees
@husnialhamdani
Labels
enhancement New feature or request

Comments

@AharonIsraelCohen
Copy link

Is your feature request related to a problem? Please describe.
I tried to update my cluster resources, I am using operator and cluster latests charts, and I noticed that there is a Rolling update
action for the leaders and right after it finished the followers starts to update as well, as a result we lost some data because
the leaders didn't managed to catch up with the followers and then the followers started to restart as well/

Describe the solution you'd like
I would like to have separate "resource" section for leaders and followers, so we could update them seperatly.

What version of redis-operator are you using?
chart version: 0.18.5
image:
@AharonIsraelCohen AharonIsraelCohen added the enhancement New feature or request label Dec 23, 2024
@drivebyer drivebyer added the help wanted Extra attention is needed label Dec 24, 2024
@husnialhamdani
Copy link
Contributor

Hi @AharonIsraelCohen,
You mean, ability to have separate "resource" (CPU/Memory requests/limits)?

@drivebyer you can assign me

@AharonIsraelCohen
Copy link
Author

Hi @AharonIsraelCohen, You mean, ability to have separate "resource" (CPU/Memory requests/limits)?

@drivebyer you can assign me

Exactly, so on cases like increasing resources we could increase follower resources first and after the cluster is balanced, to increase leaders resources as well.

@husnialhamdani husnialhamdani linked a pull request Dec 24, 2024 that will close this issue
Draft
4 tasks
@drivebyer drivebyer removed the help wanted Extra attention is needed label Dec 25, 2024
@drivebyer
Copy link
Collaborator

After thinking of this, I think we didn't need an additional field to separate resources for leader and follower. Because the actual role of Redis will change after cluster failover. That is to say, the pod under the leader statefulset may become a follower. So the additional field will be set to the wrong pod after cluster failover.

In your case, I think we need another way to enhance the data security. @AharonIsraelCohen

cc @husnialhamdani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@husnialhamdani husnialhamdani

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: separate resources section for leader and follower husnialhamdani/redis-operator
3 participants
@drivebyer @husnialhamdani @AharonIsraelCohen