Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Provenance group, echodata_filename dim may duplicate the role of filenames dim #1123

Open
emiliom opened this issue Aug 15, 2023 · 0 comments

Comments

@emiliom
Copy link
Collaborator

emiliom commented Aug 15, 2023

I'm puzzled by the use of the Provenance dimension echodata_filename in addition to filenames. Note that echodata_filename is a more recent addition. I hadn't examined the Provenance attribute aggregation features before. As far as I can see, echodata_filename seems to perform the same function as filenames, so that it looks like an unnecessary duplication of the dimension.

I am not aware of a specific case where echodata_filename does serve a different function than filenames. But I've only inspected a couple of cases. A closer examination is needed.

For reference:

  • filenames: A dimension and coordinate variable containing incremental integer indices for each source data file. Currently used only by source_filenames and, when relevant (AZFP only), meta_source_filenames. Assigned to every EchoData object during open_raw.
  • source_filenames: a convention-based variable holding file paths to source data files. Assigned to every EchoData object during open_raw.
  • echodata_filename: A dimension and coordinate variable added by combine_echodata, containing file names corresponding to the source data files used in the combination step. Note that it has no long_name attribute, so a longer description is not available.

Here's an example

image

This issue was motivated by PR #1116

@leewujung leewujung added this to the 0.8.1 milestone Aug 21, 2023
@leewujung leewujung removed this from the 0.8.1 milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants