Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporal and spatial info to compute_NASC outputs #1014

Closed
leewujung opened this issue Mar 25, 2023 · 3 comments
Closed

Add temporal and spatial info to compute_NASC outputs #1014

leewujung opened this issue Mar 25, 2023 · 3 comments
Assignees
Milestone

Comments

@leewujung
Copy link
Member

leewujung commented Mar 25, 2023

Leftover from #1005:

We should consider adding the mean time, latitude, and longitude over the NASC cells with a distance dimension to the compute_NASC output.

See discussions in #1005 (comment)

short of adding the mean time, lon and lat variables (with distance dim) that I mentioned, if we wanted to do it now.

I have mixed feeling about this, mainly two things:

  • right now the distance and depth dimensions uses the starting bin edges and not the mean or mid point of the bins (see next point) as the values -- we should probably stick with one scheme
  • for the means: should it be true means (as in the mean of the values), or should it just be the middle point of the bins?

Related to #1002

@leewujung
Copy link
Member Author

This can be closed once #1127 is merged.

@emiliom
Copy link
Collaborator

emiliom commented Oct 14, 2023

Did you mean PR #1167? #1127 is an issue.

Also, add a processing level decorator to compute_NASC in PR #1167, once compute_NASC is ready? @add_processing_level("L4*")

@leewujung leewujung modified the milestones: 0.8.1, 0.8.2 Oct 25, 2023
@leewujung
Copy link
Member Author

We can close this now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants