-
Notifications
You must be signed in to change notification settings - Fork 942
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1753 from OPCFoundation/master
Merge bug fixes in release 1.4.368 branch for Nuget update
- Loading branch information
Showing
324 changed files
with
2,069 additions
and
1,606 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| name: 🐞Bug/Issue report | ||
| description: Create an issue report to help us improve | ||
| title: "<title>" | ||
| labels: [Needs Triage] | ||
| body: | ||
| - type: checkboxes | ||
| attributes: | ||
| label: Type of issue | ||
| description: Please provide information on the type of issue. | ||
| options: | ||
| - label: Bug | ||
| required: false | ||
| - label: Enhancement | ||
| required: false | ||
| - label: Compliance | ||
| required: false | ||
| - label: Question | ||
| required: false | ||
| - label: Help wanted | ||
| required: false | ||
| - type: textarea | ||
| attributes: | ||
| label: Current Behavior | ||
| description: A clear and concise description of what the issue is. | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| attributes: | ||
| label: Expected Behavior | ||
| description: A clear and concise description of what you expected to happen. | ||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| attributes: | ||
| label: Steps To Reproduce | ||
| description: Steps to reproduce the behavior. | ||
| placeholder: | | ||
| 1. Compile Sample '...' | ||
| 2. Connect to Server '....' | ||
| 3. Browse Address space '....' | ||
| 4. Subscribe to Node '....' | ||
| 5. See error | ||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| attributes: | ||
| label: Environment | ||
| description: | | ||
| examples: | ||
| - **OS**: [Windows 10, Ubuntu, macOS] | ||
| - **Environment**: [e.g. Visual Studio 2019 16.7.2] | ||
| - **Runtime**: [e.g. .NET 4.6.2, .NET Core 3.1] | ||
| - **Nuget Version**: [e.g. 1.4.368.33] | ||
| - **Component**: [e.g. Opc.Ua.Core] | ||
| - **Server**: [e.g. Reference Server] | ||
| - **Client**: [e.g. UA Expert] | ||
| value: | | ||
| - OS: | ||
| - Environment: | ||
| - Runtime: | ||
| - Nuget Version: | ||
| - Component: | ||
| - Server: | ||
| - Client: | ||
| render: markdown | ||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| attributes: | ||
| label: Anything else? | ||
| description: | | ||
| Links? References? Log files? Code snippets? | ||
| Anything that will give us more context about the issue you are encountering! | ||
| Tip: You can attach images or log files by clicking this area to highlight it and then dragging files in. | ||
| validations: | ||
| required: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| ## Proposed changes | ||
|
|
||
| Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. | ||
|
|
||
| ## Related Issues | ||
|
|
||
| - Fixes # | ||
|
|
||
| ## Types of changes | ||
|
|
||
| What types of changes does your code introduce to Appium? | ||
| _Put an `x` in the boxes that apply_ | ||
|
|
||
| - [ ] Bugfix (non-breaking change which fixes an issue) | ||
| - [ ] Enhancement (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages) | ||
| - [ ] Documentation Update (if none of the other choices apply) | ||
|
|
||
| ## Checklist | ||
|
|
||
| _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ | ||
|
|
||
| - [ ] I have read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. | ||
| - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf). | ||
| - [ ] I ran tests locally with my changes, all passed. | ||
| - [ ] I fixed all failing tests in the CI pipelines. | ||
| - [ ] I have added tests that prove my fix is effective or that my feature works. | ||
| - [ ] I have added necessary documentation (if appropriate). | ||
| - [ ] Any dependent changes have been merged and published in downstream modules. | ||
|
|
||
| ## Further comments | ||
|
|
||
| If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: Build and Test .NET 6.0 | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
| branches: [ master ] | ||
| paths: | ||
| - '**.cs' | ||
| - '**.csproj' | ||
|
|
||
| env: | ||
| ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true' | ||
|
|
||
| jobs: | ||
| build-and-test: | ||
| name: build-and-test-${{matrix.os}} | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macOS-latest] | ||
| include: | ||
| - framework: 'net6.0' | ||
| dotnet-version: '6.0.x' | ||
| configuration: 'Release' | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup .NET ${{ matrix.dotnet-version }} | ||
| uses: actions/setup-dotnet@v1 | ||
| with: | ||
| dotnet-version: ${{ matrix.dotnet-version }} | ||
|
|
||
| - name: Build | ||
| run: dotnet build --force --framework ${{ matrix.framework }} --configuration ${{ matrix.configuration }} "UA Core Library.sln" | ||
|
|
||
| - name: Test | ||
| # note: /p:CollectCoverage=true is only used to disable deterministc builds | ||
| run: dotnet test --no-build --framework ${{ matrix.framework }} --logger trx --configuration ${{ matrix.configuration }} /p:CollectCoverage=true --collect:"XPlat Code Coverage" --settings ./Tests/coverlet.runsettings.xml --results-directory "TestResults-${{matrix.os}}-${{matrix.framework}}-${{matrix.configuration}}" "UA Core Library.sln" | ||
|
|
||
| - name: Upload test results | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: dotnet-results-${{matrix.os}}-${{matrix.framework}}-${{matrix.configuration}} | ||
| path: "TestResults-${{matrix.os}}-${{matrix.framework}}-${{matrix.configuration}}" | ||
| # Use always() to always run this step to publish test results when there are test failures | ||
| if: ${{ always() }} | ||
|
|
||
| - name: Upload to Codecov | ||
| uses: codecov/codecov-action@v2 | ||
| with: | ||
| name: codecov-umbrella | ||
| #token: ${{ secrets.CODECOV_TOKEN }} | ||
| directory: "TestResults-${{matrix.os}}-${{matrix.framework}}-${{matrix.configuration}}" | ||
| env_vars: matrix.os,matrix.dotnet-version,matrix.configuration | ||
| fail_ci_if_error: false | ||
| path_to_write_report: "./coverage/codecov_report-${{matrix.os}}-${{matrix.framework}}-${{matrix.configuration}}/" | ||
| verbose: true | ||
| if: ${{ always() }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.