plat-ls: Add support for armv8 platform flavours #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jforissier
approved these changes
Sep 4, 2017
There was a problem hiding this comment.
A couple of minor comments below.
In any case:
Acked-by: Jerome Forissier <[email protected]>
.travis.yml
Outdated
| - $make PLATFORM=ls-ls1021atwr | ||
| - $make PLATFORM=ls-ls1021aqds | ||
|
|
||
| # Layerscape ls1043ardb (ARMv8A) |
There was a problem hiding this comment.
Minor: the correct (official) spelling is ARMv8-A
MAINTAINERS.md
Outdated
| | FSL ls1021a |`Sumit Garg <[email protected]>`| | ||
| | FSL ls1021a |`Sumit Garg <[email protected]>`| | ||
| | NXP ls1043ardb |`Sumit Garg <[email protected]>`| | ||
| | NXP ls1046ardb |`Sumit Garg <[email protected]>`| |
There was a problem hiding this comment.
Minor:
I'm a bit confused about naming here. You replaced FSL with Layerscape in .travis.yml, and here you're introducing a mix of FSL and NXP. Should that be NXP Layerscape ls1021a, NXP Layerscape ls1043ardb etc. maybe?
Added support for armv8 platform flavours as follows: - PLATFORM = ls-ls1043ardb - PLATFORM = ls-ls1046ardb Signed-off-by: Sumit Garg <[email protected]> Acked-by: Jens Wiklander <[email protected]> Acked-by: Jerome Forissier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for armv8 platform flavours as follows:
Signed-off-by: Sumit Garg [email protected]