Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route matching should stop at first route match #17

Open
OKNoah opened this issue Jan 11, 2018 · 0 comments
Open

Route matching should stop at first route match #17

OKNoah opened this issue Jan 11, 2018 · 0 comments

Comments

@OKNoah
Copy link
Owner

OKNoah commented Jan 11, 2018

Currently the packages/final-server/updater.js will attempt to match all routes. This was a design mistake. Since components can already match multiple routes and methods, there's little reason to allow this, in my mind. This actually creates a big right now where the last-most route will catch provide the eventual response to a request.

If this is fixed, we can also do 404 and catch-all routes easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant