requires: check for existence of keyword - v3 #12177
Open
+116
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, "requires: foo bar" is an unknown requirement, however its not tracked, nor an error as it follows the syntax. Instead, record these unknown keywords, and fail the requirements check if any are present. A future version of Suricata may have new requires keywords, for example a check for keywords. Ticket: OISF#7418
To be used by the requires keyword to check for keyword support. Ticket: OISF#7403
For example:
requires: keyword foo;
Will require that Suricata supports the "foo" keyword.
Ticket: OISF#7403
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12177 +/- ##
==========================================
+ Coverage 49.75% 49.98% +0.22%
==========================================
Files 912 912
Lines 257055 257100 +45
==========================================
+ Hits 127895 128505 +610
+ Misses 129160 128595 -565
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time.
Pipeline 23599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket for requires keyword: https://redmine.openinfosecfoundation.org/issues/7403
Ticket for unknown requirements: https://redmine.openinfosecfoundation.org/issues/7418
SV_BRANCH=OISF/suricata-verify#2133