-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] stock_scrap_tier_validation: Migration to 17.0 #1654
Open
StefanRijnhart
wants to merge
13
commits into
OCA:17.0
Choose a base branch
from
StefanRijnhart:17.0-mig-stock_scrap_tier_validation
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] stock_scrap_tier_validation: Migration to 17.0 #1654
StefanRijnhart
wants to merge
13
commits into
OCA:17.0
from
StefanRijnhart:17.0-mig-stock_scrap_tier_validation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanRijnhart
changed the title
[17.0][MIG] stock scrap tier validation: Migration to 17.0
[17.0][MIG] stock_scrap_tier_validation: Migration to 17.0
Aug 8, 2024
StefanRijnhart
force-pushed
the
17.0-mig-stock_scrap_tier_validation
branch
from
October 3, 2024 16:01
ddaceaa
to
cc9cb1e
Compare
alan196
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical review 👍
/ocabot migration stock_scrap_tier_validation |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/
Currently translated at 100.0% (20 of 20 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/es/
StefanRijnhart
force-pushed
the
17.0-mig-stock_scrap_tier_validation
branch
from
November 25, 2024 11:11
cc9cb1e
to
7e9edd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from 15.0.
We noticed that there is a minimal scrap view that is opened when scrapping directly from manufacturing orders or stock transfers. This view opens in a popup. The popup is only saved when confirming the scrap, which is a problem because if validation is required an exception will be raised with no option to save first and then request validation.
We're proposing to open the view in the main window instead. A glue module to fix the issue in compatibility with
mrp
.