From 4919c65e1f64007946fdca42dd5e0bfc641215ef Mon Sep 17 00:00:00 2001 From: Denis Roussel Date: Fri, 23 Aug 2024 11:44:30 +0200 Subject: [PATCH] [IMP] queue_job: Don't raise a warning for valid context As the 'queue_job__no_delay' context key is the valid one to use, don't raise warnings during tests, but log it as information level. --- queue_job/utils.py | 2 +- test_queue_job/tests/test_job_auto_delay.py | 13 +++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/queue_job/utils.py b/queue_job/utils.py index 5134cd1068..4b228dcc07 100644 --- a/queue_job/utils.py +++ b/queue_job/utils.py @@ -36,5 +36,5 @@ def must_run_without_delay(env): return True if env.context.get("queue_job__no_delay"): - _logger.warning("`queue_job__no_delay` ctx key found. NO JOB scheduled.") + _logger.info("`queue_job__no_delay` ctx key found. NO JOB scheduled.") return True diff --git a/test_queue_job/tests/test_job_auto_delay.py b/test_queue_job/tests/test_job_auto_delay.py index 5549fc7487..14c1e2ed61 100644 --- a/test_queue_job/tests/test_job_auto_delay.py +++ b/test_queue_job/tests/test_job_auto_delay.py @@ -32,11 +32,16 @@ def test_auto_delay_inside_job(self): def test_auto_delay_force_sync(self): """method forced to run synchronously""" - result = ( - self.env["test.queue.job"] - .with_context(_job_force_sync=True) - .delay_me(1, kwarg=2) + with self.assertLogs(level="WARNING") as log_catcher: + result = ( + self.env["test.queue.job"] + .with_context(_job_force_sync=True) + .delay_me(1, kwarg=2) + ) + self.assertEqual( + len(log_catcher.output), 1, "Exactly one warning should be logged" ) + self.assertIn(" ctx key found. NO JOB scheduled. ", log_catcher.output[0]) self.assertTrue(result, (1, 2)) def test_auto_delay_context_key_set(self):