[MIG] hr_personal_equipment_request: Migration to 18.0

Author: BhaveshHeliconia

hr_personal_equipment_request/README.rst

@@ -17,13 +17,13 @@ Hr Personal Equipment Request
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fhr-lightgray.png?logo=github
-    :target: https://github.com/OCA/hr/tree/17.0/hr_personal_equipment_request
+    :target: https://github.com/OCA/hr/tree/18.0/hr_personal_equipment_request
     :alt: OCA/hr
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/hr-17-0/hr-17-0-hr_personal_equipment_request
+    :target: https://translation.odoo-community.org/projects/hr-18-0/hr-18-0-hr_personal_equipment_request
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/hr&target_branch=17.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/hr&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -72,7 +72,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/hr/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/hr/issues/new?body=module:%20hr_personal_equipment_request%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/hr/issues/new?body=module:%20hr_personal_equipment_request%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -87,10 +87,12 @@ Authors
 Contributors
 ------------
 
--  Alba Riera <[email protected]>
--  `APSL <https://apsl.tech>`__:
+- Alba Riera <[email protected]>
+- `APSL <https://apsl.tech>`__:
 
-   -  Antoni Marroig <[email protected]>
+  - Antoni Marroig <[email protected]>
+
+- ``Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>``\ \_
 
 Maintainers
 -----------
@@ -105,6 +107,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/hr <https://github.com/OCA/hr/tree/17.0/hr_personal_equipment_request>`_ project on GitHub.
+This module is part of the `OCA/hr <https://github.com/OCA/hr/tree/18.0/hr_personal_equipment_request>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

hr_personal_equipment_request/__manifest__.py

@@ -5,11 +5,11 @@
     "name": "Hr Personal Equipment Request",
     "summary": """
         This addon allows to manage employee personal equipment""",
-    "version": "17.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "Creu Blanca, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/hr",
-    "depends": ["product", "hr", "mail"],
+    "depends": ["product", "hr", "mail", "purchase"],
     "data": [
         "security/hr_personal_equipment_request_security.xml",
         "security/ir.model.access.csv",

hr_personal_equipment_request/models/hr_employee.py

@@ -38,7 +38,7 @@ def action_open_equipment_request(self):
             "name": _("Equipment Request"),
             "type": "ir.actions.act_window",
             "res_model": "hr.personal.equipment.request",
-            "view_mode": "tree,form",
+            "view_mode": "list,form",
             "context": {"group_by": "state"},
             "domain": [("id", "in", self.equipment_request_ids.ids)],
         }
@@ -50,6 +50,6 @@ def action_open_personal_equipment(self):
             "type": "ir.actions.act_window",
             "res_model": "hr.personal.equipment",
             "context": {"group_by": "state"},
-            "view_mode": "tree,form",
+            "view_mode": "list,form",
             "domain": [("id", "in", self.personal_equipment_ids.ids)],
         }

hr_personal_equipment_request/models/hr_personal_equipment_request.py

@@ -65,6 +65,6 @@ def action_open_personal_equipment(self):
             "name": _("Allocations"),
             "type": "ir.actions.act_window",
             "res_model": "hr.personal.equipment",
-            "view_mode": "tree,form",
+            "view_mode": "list,form",
             "domain": [("id", "in", self.line_ids.ids)],
         }

hr_personal_equipment_request/readme/CONTRIBUTORS.md

@@ -1,3 +1,4 @@
 - Alba Riera \<<[email protected]>\>
 - [APSL](https://apsl.tech):
-  - Antoni Marroig  \<<[email protected]>\>
+  - Antoni Marroig  \<<[email protected]>\>
+- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`_

hr_personal_equipment_request/static/description/index.html

@@ -8,10 +8,11 @@
 
 /*
 :Author: David Goodger ([email protected])
-:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -274,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: grey; } /* line numbers */
+pre.code .ln { color: gray; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -300,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic {
+span.problematic, pre.problematic {
   color: red }
 
 span.section-subtitle {
@@ -368,7 +369,7 @@ <h1 class="title">Hr Personal Equipment Request</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:eba98fcbc7bf28db13085a8e800b36e14717a8137678a978ab424af2a340dbcd
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/hr/tree/17.0/hr_personal_equipment_request"><img alt="OCA/hr" src="https://img.shields.io/badge/github-OCA%2Fhr-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/hr-17-0/hr-17-0-hr_personal_equipment_request"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/hr&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/hr/tree/18.0/hr_personal_equipment_request"><img alt="OCA/hr" src="https://img.shields.io/badge/github-OCA%2Fhr-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/hr-18-0/hr-18-0-hr_personal_equipment_request"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/hr&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module allows to create a personal equipment request and manage
 allocation of employee personal equipment.</p>
 <p><strong>Table of contents</strong></p>
@@ -414,7 +415,7 @@ <h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/hr/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/hr/issues/new?body=module:%20hr_personal_equipment_request%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/hr/issues/new?body=module:%20hr_personal_equipment_request%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -433,16 +434,19 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <li>Antoni Marroig &lt;<a class="reference external" href="mailto:amarroig&#64;apsl.net">amarroig&#64;apsl.net</a>&gt;</li>
 </ul>
 </li>
+<li><tt class="docutils literal">Heliconia Solutions Pvt. Ltd. <span class="pre">&lt;https://www.heliconia.io&gt;</span></tt>_</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/hr/tree/17.0/hr_personal_equipment_request">OCA/hr</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/hr/tree/18.0/hr_personal_equipment_request">OCA/hr</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

hr_personal_equipment_request/tests/test_hr_personal_equipment_request.py

@@ -10,36 +10,42 @@ class TestHRPersonalEquipmentRequest(TransactionCase):
     def setUpClass(cls):
         super().setUpClass()
         cls.product_personal_equipment_1 = cls.env["product.template"].create(
-            {
-                "name": "Product Test Personal Equipment 1",
-                "is_personal_equipment": True,
-                "uom_id": cls.env.ref("uom.product_uom_unit").id,
-            }
+            [
+                {
+                    "name": "Product Test Personal Equipment 1",
+                    "is_personal_equipment": True,
+                    "uom_id": cls.env.ref("uom.product_uom_unit").id,
+                }
+            ]
         )
         cls.product_personal_equipment_2 = cls.env["product.template"].create(
-            {
-                "name": "Product Test Personal Equipment 2",
-                "is_personal_equipment": True,
-                "uom_id": cls.env.ref("uom.product_uom_unit").id,
-            }
+            [
+                {
+                    "name": "Product Test Personal Equipment 2",
+                    "is_personal_equipment": True,
+                    "uom_id": cls.env.ref("uom.product_uom_unit").id,
+                }
+            ]
         )
         cls.user = (
             cls.env["res.users"]
             .sudo()
             .create(
-                {
-                    "name": "Test User",
-                    "login": "[email protected]",
-                    "email": "[email protected]",
-                    "groups_id": [
-                        (4, cls.env.ref("base.group_user").id),
-                        (4, cls.env.ref("hr.group_hr_user").id),
-                    ],
-                }
+                [
+                    {
+                        "name": "Test User",
+                        "login": "[email protected]",
+                        "email": "[email protected]",
+                        "groups_id": [
+                            (4, cls.env.ref("base.group_user").id),
+                            (4, cls.env.ref("hr.group_hr_user").id),
+                        ],
+                    }
+                ]
             )
         )
         cls.employee = cls.env["hr.employee"].create(
-            {"name": "Employee Test", "user_id": cls.user.id}
+            [{"name": "Employee Test", "user_id": cls.user.id}]
         )
 
         lines = [
@@ -59,11 +65,13 @@ def setUpClass(cls):
             cls.env["hr.personal.equipment.request"]
             .with_user(cls.user.id)
             .create(
-                {
-                    "name": "Personal Equipment Request Test",
-                    "employee_id": cls.employee.id,
-                    "line_ids": [(0, 0, line) for line in lines],
-                }
+                [
+                    {
+                        "name": "Personal Equipment Request Test",
+                        "employee_id": cls.employee.id,
+                        "line_ids": [(0, 0, line) for line in lines],
+                    }
+                ]
             )
         )
 

hr_personal_equipment_request/views/hr_personal_equipment_request_views.xml

@@ -56,10 +56,10 @@
                         <page string="Personal Equipment">
                             <field
                                 name="line_ids"
-                                mode="tree,form"
+                                mode="list,form"
                                 readonly="state != 'draft'"
                             >
-                                <tree editable="bottom" name="equipment_lines">
+                                <list editable="bottom" name="equipment_lines">
                                     <field name="product_id" />
                                     <field name="quantity" />
                                     <field name="product_uom_id" />
@@ -70,7 +70,7 @@
                                     <field name="state" readonly="1" />
                                     <field name="equipment_request_id" invisible="1" />
                                     <field name="employee_id" invisible="1" />
-                                </tree>
+                                </list>
                                 <form>
                                     <header>
                                         <button
@@ -110,11 +110,7 @@
                         </page>
                     </notebook>
                 </sheet>
-                <div class="oe_chatter">
-                    <field name="message_follower_ids" widget="mail_followers" />
-                    <field name="activity_ids" widget="mail_activity" />
-                    <field name="message_ids" widget="mail_thread" />
-                </div>
+                <chatter />
             </form>
         </field>
     </record>
@@ -139,27 +135,27 @@
             </search>
         </field>
     </record>
-    <record model="ir.ui.view" id="hr_personal_equipment_request_tree_view">
+    <record model="ir.ui.view" id="hr_personal_equipment_request_list_view">
         <field
             name="name"
-        >hr.personal.equipment.request.tree (in hr_personal_equipment_request)</field>
+        >hr.personal.equipment.request.list (in hr_personal_equipment_request)</field>
         <field name="model">hr.personal.equipment.request</field>
         <field name="arch" type="xml">
-            <tree
+            <list
                 decoration-success="state=='accepted'"
                 decoration-muted="state=='cancelled'"
             >
                 <field name="name" />
                 <field name="employee_id" groups="hr.group_hr_user" />
                 <field name="create_date" />
                 <field name="state" />
-            </tree>
+            </list>
         </field>
     </record>
     <record model="ir.actions.act_window" id="hr_personal_equipment_request_act_window">
         <field name="name">Personal Equipment Request</field>
         <field name="res_model">hr.personal.equipment.request</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="domain">[]</field>
         <field
             name="context"

hr_personal_equipment_request/views/hr_personal_equipment_views.xml

@@ -63,21 +63,17 @@
                         />
                     </group>
                 </sheet>
-                <div class="oe_chatter">
-                    <field name="message_follower_ids" widget="mail_followers" />
-                    <field name="activity_ids" widget="mail_activity" />
-                    <field name="message_ids" widget="mail_thread" />
-                </div>
+                <chatter />
             </form>
         </field>
     </record>
-    <record model="ir.ui.view" id="hr_personal_equipment_tree_view">
+    <record model="ir.ui.view" id="hr_personal_equipment_list_view">
         <field
             name="name"
-        >hr.personal.equipment.tree (in hr_personal_equipment_request)</field>
+        >hr.personal.equipment.list (in hr_personal_equipment_request)</field>
         <field name="model">hr.personal.equipment</field>
         <field name="arch" type="xml">
-            <tree
+            <list
                 create="0"
                 decoration-info="state=='accepted'"
                 decoration-success="state=='valid'"
@@ -92,7 +88,7 @@
                 <field name="start_date" />
                 <field name="state" />
                 <field name="equipment_request_id" invisible="1" />
-            </tree>
+            </list>
         </field>
     </record>
     <record model="ir.ui.view" id="hr_personal_equipment_search_view">
@@ -149,7 +145,7 @@
     <record model="ir.actions.act_window" id="hr_personal_equipment_act_window">
         <field name="name">Allocations</field>
         <field name="res_model">hr.personal.equipment</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="domain">[]</field>
         <field name="context">{'search_default_filter_valid_state':1}</field>
     </record>

hr_personal_equipment_request/views/product_template_views.xml

@@ -9,12 +9,6 @@
         <field name="model">product.template</field>
         <field name="inherit_id" ref="product.product_template_form_view" />
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='purchase_ok']/.." position="after">
-                <div>
-                    <field name="is_personal_equipment" />
-                    <label for="is_personal_equipment" />
-                </div>
-            </xpath>
             <!-- This page serves as a hook if additional fields are needed> -->
             <xpath expr="//page[@name='inventory']" position="after">
                 <page
@@ -25,4 +19,19 @@
             </xpath>
         </field>
     </record>
+    <record model="ir.ui.view" id="view_product_supplier_inherit">
+        <field
+            name="name"
+        >product.template.supplier.form (in hr_personal_equipment_request)</field>
+        <field name="model">product.template</field>
+        <field name="inherit_id" ref="purchase.view_product_supplier_inherit" />
+        <field name="arch" type="xml">
+            <xpath expr="//field[@name='purchase_ok']/.." position="after">
+                <div>
+                    <field name="is_personal_equipment" />
+                    <label for="is_personal_equipment" />
+                </div>
+            </xpath>
+        </field>
+    </record>
 </odoo>