Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Principle #7 relations - automated validation mechanism #981

Open
nataled opened this issue Aug 6, 2019 · 2 comments
Open

Principle #7 relations - automated validation mechanism #981

nataled opened this issue Aug 6, 2019 · 2 comments
Labels
attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. principles Issues related to Foundry principles

Comments

@nataled
Copy link
Contributor

nataled commented Aug 6, 2019

Here, we discuss the types of automated checks that could be implemented to see if a particular ontology is meeting principle 7. We consider the use of RO for relations as meeting the objective, even if the RO relation is undefined or poorly defined (not ideal, but better than minting new relations covering the same object property).

Validation of relations:

  1. Extract all object properties.
  2. Identify any that do not use RO purls:
    a) Do any share a label with a RO relation? If so, throw an Error
    b) For those that have no label in common with RO, throw a Warning

The above is a suitable start for ROBOT. However, ideally, for the sake of ontology reviews we'd have the following tagged:

  1. RO purl relations used
  2. Non-RO relations that share a label with RO (2a above)
  3. Non-RO relations that share a label with relations in another ontology
  4. Non-RO relations that lack a shared label with relations in any other ontology
  5. Non-RO relations in the tested ontology that lack definition in that ontology

Note that while 1, 2, 3, and 4 are mutually exclusive, 5 is not mutually exclusive with 2, 3, or 4.

@nataled nataled added attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools labels Aug 6, 2019
@nataled nataled self-assigned this Aug 6, 2019
@beckyjackson beckyjackson self-assigned this Aug 9, 2019
@cmungall cmungall added the principles Issues related to Foundry principles label Nov 22, 2019
@cmungall cmungall changed the title Principle #7 automated validation mechanism Principle #7 relations - automated validation mechanism Nov 22, 2019
@wdduncan wdduncan added the automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. label Apr 28, 2020
@nlharris
Copy link
Contributor

What's the status of this? Is this covered by the dashboard checks?

@nataled
Copy link
Contributor Author

nataled commented Jan 26, 2022

Unsure of the status. The EWG has been going through old tickets at each meeting as time allows. This and related tickets regarding automated validation are for discussion about whether or not the dashboard check is an accurate check for the principle.

@beckyjackson beckyjackson removed their assignment May 25, 2022
@nataled nataled removed the attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles label Dec 20, 2022
@nataled nataled removed their assignment Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. principles Issues related to Foundry principles
Projects
None yet
Development

No branches or pull requests

5 participants