Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading FoodOn to work with COB as top-level #241

Open
ddooley opened this issue May 3, 2023 · 3 comments
Open

Upgrading FoodOn to work with COB as top-level #241

ddooley opened this issue May 3, 2023 · 3 comments

Comments

@ddooley
Copy link
Contributor

ddooley commented May 3, 2023

I thought I'd report out about the FoodOn conversion to COB. The main effort is to adapt all the existing MIREOT term importing from other sources to not use BFO upper level. At moment FoodOn build is still working with OntoFox which enables us to stop the import of a term's ancestors past a certain parent, so it works well in giving the list of COB top level terms, and thereby not have to retrieve BFO upper level terms even though they are situated under them often.

A few things do come up:
image

COB's erroneous "material entity" id will be taken care of soon I see.

UBERON and CARO have this thing called "biological entity". Does that fit in COB? Or do I place their subClass "anatomical entity" under "material entity" directly?

UBERON has "life cycle". Do we fudge that into "process"?

I'm bringing OWLTime in to cover describing durations of processes. Where can I place time:Duration? I had brought in "one-dimensional temporal region" as a parent from BFO, but where would that fit?

Thanks for advice,

Damion

@matentzn
Copy link
Contributor

matentzn commented May 4, 2023

@ddooley thank you for taking the time to write this! I don't know any of the answers, but I want to give a big thumbs up for the work you have been doing integrating COB and identifying issues!

@cmungall
Copy link
Contributor

@ddooley
Copy link
Contributor Author

ddooley commented Aug 19, 2024

Ok, update is FoodOn has

  • eliminated all CARO references;
  • We await life stage resolution;
  • the time:Duration we are intending to use comes with all the data properties necessary to describe duration in a number of convenient ways. Agree that duration in OBO Foundry is a process characteristic. But using OWL_Time conveniently, it would be great if BFO/COB:process could be a mixin subclass of time:properInterval (subclass of time:TemporalEntity). As it is we have to use an extra time:hasTime object property that seems logically redundant:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants