-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.2: Advertises support for JSON Schema Draft-05 despite advice to the contrary. #2049
Comments
It says based on. Is there a specific problem this is causing you here or are you just thinking about semantics? Sorry if I'm sounding difficult here. OAS is already looking to move to JSON Schema draft 2019-09 full support for 3.1. I'm not sure what the gain would be on resolving this issue. |
Just semantics. If you want to resolve in 3.1 and close this as Won't Fix, that seems reasonable to me. I was just chasing down what seemed like disparities between the spec and its use in Kubernetes. |
OK. I think this is likely to be resolved before 3.1. |
@Capstan several things (I'm another of the JSON Schema editors, and I work with the OpenAPI Technical Steering Council on convergence between JSON Schema and the OpenAPI Specification):
So nothing is going to be done with this that isn't already being done, and I recommend that you or the TSC close this (@Relequestual and I cannot as this is not our repo) and just keep an eye on 3.1 via the referenced issues and PRs, and the overall 3.1 tracking issue #2025. |
@handrews Thanks so much for the detailed reply! I'll close this out. Wrt the OAS Schema Object, I had not thought to use it in an instance of said object, but simply in the schema.json that represents OAS itself. But that's moot given the other advice around not to use draft-5. |
re: http://json-schema.org/draft-06/json-schema-release-notes.html#q-what-happened-to-draft-05
schema.json correctly references Draft-04 in its
$schema
property, but the spec's Data Types section says that they're based on JSON Schema Specification Wright Draft 00. The JSON Schema org specifically advises not to implement or advertise support for this draft.If OpenAPI doesn't use anything specific from Draft-05, I would suggest amending the spec to just refer to Draft-04 and bring it in-line with the use from the published schema.
Related to #1032.
The text was updated successfully, but these errors were encountered: