Skip to content

Commit 2499167

Browse files
authored
Merge pull request #5039 from ralfhandl/main-enable-auto-merge-for-sync-prs
main: turn auto-merge for sync PRs back on and describe it in CONTRIBUTING
2 parents 191a722 + af05e68 commit 2499167

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.github/workflows/sync-dev-to-vX.Y-dev.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,11 @@ jobs:
6262
--title "$BASE: sync with $HEAD" \
6363
--body "Merge relevant changes from \`$HEAD\` into \`$BASE\`.")
6464
echo ""
65-
echo "PR to sync $DEV_BRANCH: $PR"
65+
echo "PR to sync $BASE with $HEAD: $PR"
6666
sleep 10 # allow status checks to be triggered
6767
6868
gh pr checks $PR --watch --required || continue
69-
# gh pr merge $PR --merge --admin
69+
gh pr merge $PR --merge --admin
7070
done
7171
env:
7272
GH_TOKEN: ${{ steps.generate-token.outputs.token }}

CONTRIBUTING.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -530,10 +530,9 @@ gitGraph TB:
530530

531531
To keep changes in sync, we have some GitHub actions that open pull requests to take changes from `main` onto the `dev` branch, and from `dev` to each active version branch.
532532

533-
- `sync-main-to-dev` opens a pull request with all the changes from the `main` branch that aren't yet included on `dev`.
534-
- `sync-dev-to-vX.Y-dev` opens pull requests with all the changes from `dev` that aren't yet included on the corresponding `vX.Y-dev` branch.
533+
- `sync-main-to-dev` opens a pull request with all the changes from the `main` branch that aren't yet included on `dev`. This pull request needs a single approval from either maintainers or TSC and can be merged.
534+
- `sync-dev-to-vX.Y-dev` opens pull requests with all the changes from `dev` that aren't yet included on the corresponding `vX.Y-dev` branch. These pull requests are automatically merged if all required status checks pass.
535535

536-
These need a single approval from either maintainers or TSC and can be merged.
537536
The aim is to bring build script and repository documentation changes to the other branches.
538537
Published versions of the specifications and schemas will also move across branches with this approach.
539538

0 commit comments

Comments
 (0)