Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test WASM support in CI #142

Open
gagbo opened this issue Mar 29, 2022 · 5 comments
Open

Test WASM support in CI #142

gagbo opened this issue Mar 29, 2022 · 5 comments
Labels
good first issue Good for newcomers

Comments

@gagbo
Copy link

gagbo commented Mar 29, 2022

Hello,

It would be nice, if possible to bump the zstd dependency to 0.11 to be able to use this crate on WASM targets. To be honest I'm not entirely sure this is possible, or whether the bump would be enough. I'll probably try eventually in some point in the future, I'm mostly making this issue to raise awareness

@hariria

This comment was marked as resolved.

@hariria

This comment was marked as resolved.

@indygreg

This comment was marked as resolved.

@Nemo157
Copy link
Member

Nemo157 commented May 11, 2022

Sorry about the delay, I've merged and published #144 finally. I'd like to keep this issue open for adding CI testing on wasm32-wasi if possible.

@Nemo157
Copy link
Member

Nemo157 commented May 11, 2022

Blockers for testing on wasm32-wasi:

  • proptest uses forking
  • ntest::timeout uses threads

Quickly deleting those dependencies from the tests I was able to successfully run the tests on arch after installing libc-wasi with:

CFLAGS='-iwithsysroot /usr/share/wasi-sysroot/include' cargo test --target wasm32-wasi --features zstd,all-implementations

It looks like everything except xz/lzma compiles ok, that uses pthread.h which doesn't exist, it's hopefully possible to disable that by adding some extra build-configuration somewhere.

I'll think about what to do about proptest/ntest and come back to this later.

@robjtede robjtede changed the title Bump zstd for WASM support Test WASM support Jan 17, 2024
@robjtede robjtede changed the title Test WASM support Test WASM support in CI Jan 17, 2024
@robjtede robjtede added the good first issue Good for newcomers label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants