-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Minor: missing newline after status output #414
Comments
I'm actually unable to reproduce this behavior. This works perfectly fine on the newest 3.1.0 release on all shells I tested, including GNU bash What kind of shell are you using? The fact that we didn't change anything in the way |
bash 5.1.16(1) on Gentoo and 5.1.4 on Debian. I run the precompiled pueue(d) binaries on all machines.
It used to work fine in the previous version 3.0.1 (and all previous ones). To exclude misconfiguration or user environment issues on my part, I spun up a virtual machine and started a Ubuntu 22.10 live session. I downloaded the pueue(d) binaries for versions 3.0.1 and 3.1.0 and executed them:
Note the final
The final new line character is missing. The same happens with a non-empty task list. Good in version 3.0.1:
Broken in version 3.1.0:
Without knowing anything about the code, to me it looks like there are some missing newlines in |
Also, it seems that zsh tries to preserve partial lines when emitting the prompt by default. Maybe this behaviour masked the visibility of the reported issue. |
You were completely right, there was actually a change between v3.0.1 and v3.1.0. I'm still confused that we're getting different behaviors on the same bash version accross systems, as I'm still unable to reproduce the behavior that can be observed on your machines. Anyhow. The usage of
|
Yes, it's strange that bash seems to behave differently. It would be really interesting to know the cause. Anyway, thanks for digging into the issue, the MR makes the new lines reappear:
I looked at several other status and log outputs, they are all fine. Thanks, very much appreciated! |
Describe the bug
The
pueue status
command output is missing a final newline:Steps to reproduce the bug
Just run
pueue status
.Expected behavior
I would expect a final newline, so that the command prompt is at the beginning of a new line:
Additional context
The text was updated successfully, but these errors were encountered: