Revert functionality to have static graph-based restore write arguments to standard input #5080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
previously approved these changes
Mar 8, 2023
erdembayar
approved these changes
Mar 8, 2023
zivkan
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Regression? Last working version:
Description
This reverts the original implementation of having static graph-based restore write arguments to standard input (19a4170) as well as the follow-up change to fix the scenario where the console stream contains a byte order mark (6512bed.).
After the change, the bug around console encodings was shipped in 17.5 and even after the fix for 17.6, it still crashes under certain conditions.
Reverting this means that the original issue NuGet/Home#11968 will be a bug again but I'm going to work on redoing all of this functionality later.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation