From 9c773b4e0fe966998447d4ab34c4a45c399e5ac8 Mon Sep 17 00:00:00 2001 From: Nikolche Kolev Date: Fri, 15 Jan 2021 16:18:00 -0800 Subject: [PATCH 1/9] work --- .github/PULL_REQUEST_TEMPLATE.md | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ec7cf79346a..5f6c8bdd421 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,16 +1,27 @@ + ## Bug -Fixes: Link_to_issue (search [NuGet/Home](https://github.com/NuGet/Home/issues), and create one if you can't find a suitable issue) -Regression: Yes/No -* Last working version: -* How are we preventing it in future: + + +Fixes: +Regression? Last working version: -## Fix +## Description + -Details: Details_about_the_fix +## PR Checklist -## Testing/Validation +- [ ] PR has a meaningful title +- [ ] PR has a linked issue. +- [ ] Described changes -Tests Added: Yes/No -Reason for not adding tests: -Validation: +- Tests: + - [ ] Automated tests added + - [ ] If applicable, manual tests performed +- *OR* +- [ ] Tests exception + + +- [ ] Documentation PR or issue filled +- *OR* +- [ ] N/A From b73dc04f62d9c084a82d23fc5bd8de5ccfb5f77d Mon Sep 17 00:00:00 2001 From: Nikolche Kolev Date: Fri, 15 Jan 2021 16:19:17 -0800 Subject: [PATCH 2/9] work --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5f6c8bdd421..190a3904677 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -18,10 +18,12 @@ Regression? Last working version: - Tests: - [ ] Automated tests added - [ ] If applicable, manual tests performed -- *OR* +- **OR** - [ ] Tests exception +- **OR** +- [ ] Infrastructure - [ ] Documentation PR or issue filled -- *OR* +- **OR** - [ ] N/A From a2bb05add9bbafc1298f1434d1d4317e4be6c548 Mon Sep 17 00:00:00 2001 From: Nikolche Kolev Date: Fri, 15 Jan 2021 16:21:58 -0800 Subject: [PATCH 3/9] simplify template --- .github/PULL_REQUEST_TEMPLATE.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 190a3904677..95fa5e235ae 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -19,11 +19,12 @@ Regression? Last working version: - [ ] Automated tests added - [ ] If applicable, manual tests performed - **OR** -- [ ] Tests exception -- **OR** -- [ ] Infrastructure +- [ ] Test exception +- **OR** +- [ ] N/A + - [ ] Documentation PR or issue filled - **OR** - [ ] N/A From 9ee050ad6c6a6cb874d86ef01affb7c64497a1b1 Mon Sep 17 00:00:00 2001 From: Nikolche Kolev Date: Fri, 15 Jan 2021 16:29:07 -0800 Subject: [PATCH 4/9] work --- .github/PULL_REQUEST_TEMPLATE.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 95fa5e235ae..37c8ca65ede 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,14 +15,14 @@ Regression? Last working version: - [ ] PR has a linked issue. - [ ] Described changes -- Tests: - - [ ] Automated tests added - - [ ] If applicable, manual tests performed -- **OR** - -- [ ] Test exception -- **OR** -- [ ] N/A + - Tests: + - [ ] Automated tests added + - [ ] If applicable, manual tests performed + - **OR** + + - [ ] Test exception + - **OR** + - [ ] N/A - [ ] Documentation PR or issue filled From 30c65570bc93fa0ce876153b1326f011078added Mon Sep 17 00:00:00 2001 From: Nikolche Kolev Date: Fri, 15 Jan 2021 16:29:50 -0800 Subject: [PATCH 5/9] work --- .github/PULL_REQUEST_TEMPLATE.md | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 37c8ca65ede..a7fdff87a7e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,14 +15,13 @@ Regression? Last working version: - [ ] PR has a linked issue. - [ ] Described changes - - Tests: - - [ ] Automated tests added - - [ ] If applicable, manual tests performed - - **OR** - - - [ ] Test exception - - **OR** - - [ ] N/A +- [ ] Automated tests added + - [ ] If applicable, manual tests performed +- **OR** + +- [ ] Test exception +- **OR** +- [ ] N/A - [ ] Documentation PR or issue filled From aa3689da021ddb8806f045b140a2c94225d22925 Mon Sep 17 00:00:00 2001 From: Nikolche Kolev Date: Fri, 15 Jan 2021 16:30:21 -0800 Subject: [PATCH 6/9] work --- .github/PULL_REQUEST_TEMPLATE.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a7fdff87a7e..eb369d1b80d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,6 +15,7 @@ Regression? Last working version: - [ ] PR has a linked issue. - [ ] Described changes + - [ ] Automated tests added - [ ] If applicable, manual tests performed - **OR** @@ -23,6 +24,7 @@ Regression? Last working version: - **OR** - [ ] N/A + - [ ] Documentation PR or issue filled - **OR** From 1e956aacbbee86928c829d0f64496ae67b579d49 Mon Sep 17 00:00:00 2001 From: Nikolche Kolev Date: Fri, 15 Jan 2021 16:30:47 -0800 Subject: [PATCH 7/9] work --- .github/PULL_REQUEST_TEMPLATE.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index eb369d1b80d..1b48fe382b4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,16 +15,13 @@ Regression? Last working version: - [ ] PR has a linked issue. - [ ] Described changes - - [ ] Automated tests added - - [ ] If applicable, manual tests performed - **OR** - [ ] Test exception - **OR** - [ ] N/A - - [ ] Documentation PR or issue filled - **OR** From 38a831cd565cef0f0254e9537c76d586d91e456f Mon Sep 17 00:00:00 2001 From: Nikolche Kolev Date: Fri, 15 Jan 2021 16:32:17 -0800 Subject: [PATCH 8/9] work --- .github/PULL_REQUEST_TEMPLATE.md | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1b48fe382b4..a5d45e662fa 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,14 +15,16 @@ Regression? Last working version: - [ ] PR has a linked issue. - [ ] Described changes -- [ ] Automated tests added -- **OR** - -- [ ] Test exception -- **OR** -- [ ] N/A +- **Tests** + - [ ] Automated tests added + - **OR** + + - [ ] Test exception + - **OR** + - [ ] N/A - -- [ ] Documentation PR or issue filled -- **OR** -- [ ] N/A +- **Documentation** + + - [ ] Documentation PR or issue filled + - **OR** + - [ ] N/A From 8da52014117b4d86e14d909c7ddd941f47b36ae8 Mon Sep 17 00:00:00 2001 From: Nikolche Kolev Date: Fri, 15 Jan 2021 16:32:57 -0800 Subject: [PATCH 9/9] work --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a5d45e662fa..aa3787e2de3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,6 +4,7 @@ Fixes: + Regression? Last working version: ## Description