Allow Floating Versions in PM UI (#4478)

* Allow Floating Versions in PM UI

Author: martinrrm

Diff for: src/NuGet.Clients/NuGet.PackageManagement.UI/Actions/UIActionEngine.cs

@@ -835,6 +835,7 @@ private async Task<IReadOnlyList<ProjectAction>> GetActionsAsync(
                     includePrelease,
                     uiService.DependencyBehavior,
                     packageSourceNames,
+                    userAction.VersionRange,
                     token);
 
                 results.AddRange(actions);

Diff for: src/NuGet.Clients/NuGet.PackageManagement.UI/DisplayVersion.cs

@@ -36,6 +36,19 @@ public DisplayVersion(
             bool autoReferenced = false,
             bool isDeprecated = false,
             string versionFormat = "N")
+            : this(range, version: null, additionalInfo, isValidVersion, isCurrentInstalled, autoReferenced, isDeprecated, versionFormat)
+        {
+        }
+
+        public DisplayVersion(
+            VersionRange range,
+            NuGetVersion version,
+            string additionalInfo,
+            bool isValidVersion = true,
+            bool isCurrentInstalled = false,
+            bool autoReferenced = false,
+            bool isDeprecated = false,
+            string versionFormat = "N")
         {
             if (versionFormat == null)
             {
@@ -48,13 +61,13 @@ public DisplayVersion(
 
             IsValidVersion = isValidVersion;
 
-            Version = range.MinVersion;
+            Version = version ?? range.MinVersion;
             IsCurrentInstalled = isCurrentInstalled;
             AutoReferenced = autoReferenced;
             IsDeprecated = isDeprecated;
 
             // Display a single version if the range is locked
-            if (range.HasLowerAndUpperBounds && range.MinVersion == range.MaxVersion)
+            if (range.OriginalString == null && range.HasLowerAndUpperBounds && range.MinVersion == range.MaxVersion)
             {
                 var formattedVersionString = Version.ToString(versionFormat, VersionFormatter.Instance);
 

Diff for: src/NuGet.Clients/NuGet.PackageManagement.UI/Models/DetailControlModel.cs

@@ -61,6 +61,8 @@ protected DetailControlModel(
 
             // hook event handler for dependency behavior changed
             _options.SelectedChanged += DependencyBehavior_SelectedChanged;
+
+            _versions = new ItemsChangeObservableCollection<DisplayVersion>();
         }
 
         /// <summary>
@@ -70,6 +72,8 @@ public virtual void CleanUp()
         {
         }
 
+        public ICollectionView VersionsView { get; set; }
+
         public void Dispose()
         {
             Dispose(disposing: true);
@@ -539,16 +543,39 @@ private string GetPackageDeprecationAlternatePackageText(AlternatePackageMetadat
         protected abstract Task CreateVersionsAsync(CancellationToken cancellationToken);
 
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields")]
-        protected List<DisplayVersion> _versions;
+        protected ItemsChangeObservableCollection<DisplayVersion> _versions;
 
         // The list of versions that can be installed
-        public List<DisplayVersion> Versions
+        public ItemsChangeObservableCollection<DisplayVersion> Versions
         {
             get { return _versions; }
         }
 
         public virtual void OnSelectedVersionChanged() { }
 
+        private string _userInput;
+        public string UserInput
+        {
+            get
+            {
+                return _userInput;
+            }
+            set
+            {
+                if (_userInput != value)
+                {
+                    _userInput = value;
+
+                    if (Versions != null)
+                    {
+                        Versions.Refresh();
+                    }
+
+                    OnPropertyChanged(nameof(UserInput));
+                }
+            }
+        }
+
         private DisplayVersion _selectedVersion;
 
         public DisplayVersion SelectedVersion
@@ -639,7 +666,7 @@ private async ValueTask SelectedVersionChangedAsync(PackageItemViewModel package
         }
 
         // Calculate the version to select among _versions and select it
-        protected void SelectVersion()
+        protected void SelectVersion(NuGetVersion latestVersion = null)
         {
             if (_versions.Count == 0)
             {
@@ -656,12 +683,37 @@ protected void SelectVersion()
                 (_versions.Any(v => v != null && !v.IsValidVersion) &&
                     _versions.IndexOf(SelectedVersion) > _versions.IndexOf(_versions.FirstOrDefault(v => v != null && !v.IsValidVersion))))
             {
-                // Select the installed version by default.
-                // Otherwise, select the first version in the version list.
-                var possibleVersions = _versions.Where(v => v != null);
-                SelectedVersion =
-                    possibleVersions.FirstOrDefault(v => v.Version.Equals(_searchResultPackage.InstalledVersion))
-                    ?? possibleVersions.FirstOrDefault(v => v.IsValidVersion);
+                // The project level is the only one that has an editable combobox and we can only see one project.
+                if (!IsSolution && _nugetProjects.Count() == 1 && _nugetProjects.First().ProjectStyle.Equals(ProjectModel.ProjectStyle.PackageReference))
+                {
+                    // For the Updates and Browse tab we select the latest version, for the installed tab
+                    // select the installed version by default. Otherwise, select the first version in the version list.
+                    IEnumerable<DisplayVersion> possibleVersions = _versions.Where(v => v != null);
+                    if (_filter.Equals(ItemFilter.UpdatesAvailable) || _filter.Equals(ItemFilter.All))
+                    {
+                        SelectedVersion = possibleVersions.FirstOrDefault(v => v.Range.OriginalString.Equals(latestVersion.ToString(), StringComparison.OrdinalIgnoreCase));
+                        UserInput = SelectedVersion.ToString();
+                    }
+                    else
+                    {
+                        SelectedVersion =
+                            possibleVersions.FirstOrDefault(v => StringComparer.OrdinalIgnoreCase.Equals(v.Range?.OriginalString, _searchResultPackage?.AllowedVersions?.OriginalString))
+                            ?? possibleVersions.FirstOrDefault(v => v.IsValidVersion);
+                        UserInput = _searchResultPackage.AllowedVersions?.OriginalString ?? SelectedVersion.ToString();
+                    }
+
+                    if (FirstDisplayedVersion == null)
+                    {
+                        FirstDisplayedVersion = SelectedVersion;
+                    }
+                }
+                else
+                {
+                    var possibleVersions = _versions.Where(v => v != null);
+                    SelectedVersion =
+                        possibleVersions.FirstOrDefault(v => v.Version.Equals(_searchResultPackage.InstalledVersion))
+                        ?? possibleVersions.FirstOrDefault(v => v.IsValidVersion);
+                }
             }
         }
 
@@ -674,10 +726,14 @@ public void ClearVersions()
             if (_versions != null)
             {
                 _versions.Clear();
+                FirstDisplayedVersion = null;
                 OnPropertyChanged(nameof(Versions));
             }
         }
 
+        // Because filtering affects the versions list, we want to display every version when it's opened the first time.
+        public DisplayVersion FirstDisplayedVersion { get; set; }
+
         public abstract bool IsSolution { get; }
 
         private string _optionsBlockedMessage;
@@ -786,6 +842,19 @@ public bool InstalledVersionIsAutoReferenced
             }
         }
 
+        private string _previousSelectedVersion;
+        public string PreviousSelectedVersion
+        {
+            get
+            {
+                return _previousSelectedVersion ?? string.Empty;
+            }
+            set
+            {
+                _previousSelectedVersion = value;
+            }
+        }
+
         protected void SetAutoReferencedCheck(NuGetVersion installedVersion)
         {
             var autoReferenced = installedVersion != null

Diff for: src/NuGet.Clients/NuGet.PackageManagement.UI/Models/ItemsChangeObservableCollectionBase.cs

@@ -0,0 +1,21 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System.Collections.ObjectModel;
+using System.Collections.Specialized;
+
+namespace NuGet.PackageManagement.UI
+{
+    /// <summary>
+    /// When we bind to an <see cref="ObservableCollection{T}">ObservableCollection</see>, and change Filter criteria based on user input, the WPF binding mechanism doesn't know to refresh the View.
+    /// This collection provides an event to say the entire collection needs to be re-evaluated, without raising events for each item, and without refreshing the entire View.
+    /// </summary>
+    /// <typeparam name="T"></typeparam>
+    public class ItemsChangeObservableCollection<T> : ObservableCollection<T>
+    {
+        public void Refresh()
+        {
+            OnCollectionChanged(new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Reset));
+        }
+    }
+}