Skip to content

Commit 5ac16d7

Browse files
erdembayarerdembayar
authored
Revert "Stop using FileSystem and Common submodules (#4536)" (#4595)
This reverts commit cebb690.
1 parent 2d93510 commit 5ac16d7

File tree

26 files changed

+568
-85
lines changed

26 files changed

+568
-85
lines changed

Diff for: ‎.gitmodules

+8
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
[submodule "submodules/FileSystem"]
2+
path = submodules/FileSystem
3+
url = https://github.com/NuGet/FileSystem.git
4+
branch = NuGet/SubModuleIntegration
5+
[submodule "submodules/Common"]
6+
path = submodules/Common
7+
url = https://github.com/aspnet/Common.git
8+
branch = NuGet/SubModuleIntegration
19
[submodule "submodules/NuGet.Build.Localization"]
210
path = submodules/NuGet.Build.Localization
311
url = https://github.com/NuGet/NuGet.Build.Localization.git

Diff for: ‎build/bootstrap.proj

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<PackageDownload Include="Microsoft.Web.Xdt" version="[3.0.0]" />
1919
<PackageDownload Include="Newtonsoft.Json" version="[13.0.1]" />
2020
<PackageDownload Include="NuGet.Client.EndToEnd.TestData" version="[1.0.0]" />
21-
<PackageDownload Include="NuGetValidator" version="[2.0.5]" />
21+
<PackageDownload Include="NuGetValidator" version="[2.0.3]" />
2222
</ItemGroup>
2323

2424
</Project>

Diff for: ‎build/packages.targets

-3
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@
3636
<PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.8" />
3737
<PackageReference Update="Microsoft.DataAI.NuGetRecommender.Contracts" Version="2.1.0" />
3838
<PackageReference Update="Microsoft.Extensions.CommandLineUtils.Sources" Version="$(MicrosoftExtensionsCommandLineUtilsSourcesPackageVersion)" />
39-
<PackageReference Update="Microsoft.Extensions.FileSystemGlobbing" Version="5.0.0"/>
40-
<PackageReference Update="Microsoft.Extensions.FileProviders.Abstractions" Version="5.0.0" />
4139
<PackageReference Update="Microsoft.Internal.VisualStudio.Shell.Framework" Version="$(VSFrameworkVersion)" />
4240
<PackageReference Update="Microsoft.SourceLink.GitHub" Version="1.0.0" />
4341
<PackageReference Update="Microsoft.TeamFoundationServer.ExtendedClient" Version="$(VSServicesVersion)" />
@@ -52,7 +50,6 @@
5250
<PackageReference Update="Newtonsoft.Json" Version="$(NewtonsoftJsonPackageVersion)" />
5351
<PackageReference Update="SharpZipLib" Version="1.3.3" />
5452
<PackageReference Update="System.ComponentModel.Composition" Version="$(SystemComponentModelCompositionPackageVersion)" />
55-
<PackageReference Update="System.Runtime.Serialization.Primitives" Version="$(SystemPackagesVersion)" />
5653
<!--
5754
The Microsoft.VisualStudio.SDK metapackage brings in System.Threading.Tasks.Dataflow 4.11.1 (assembly version 4.9.5.0).
5855
However, our MSBuild integration tests use Microsoft.Build 16.8.0, which requires System.Threading.Tasks.Dataflow 4.9.0 (assembly version 4.9.3.0).

Diff for: ‎eng/pipelines/templates/Build_and_UnitTest.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ steps:
435435
inputs:
436436
artifactName: LocValidationLogs
437437
targetPath: "$(Build.Repository.LocalPath)\\logs\\LocalizationValidation"
438-
condition: "and(succeededOrFailed(), eq(variables['BuildRTM'], 'false'))"
438+
condition: "and(succeeded(), eq(variables['BuildRTM'], 'false'))"
439439

440440
# Use dotnet msbuild instead of MSBuild CLI.
441441
# Using MSBuild CLI results in an assembly binding failure for NuGet.Common.dll 4.4.0.3 because Microsoft.DotNet.Build.Tasks.Feed.dll references SleetLib.dll which references NuGet.Common 4.4.0.3.

Diff for: ‎scripts/cibuild/BuildValidator.ps1

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ param
3838

3939
if ($BuildRTM -eq 'false')
4040
{
41-
$NuGetValidator = [System.IO.Path]::Combine($RepoRoot, 'packages', 'nugetvalidator', '2.0.5', 'tools', 'NuGetValidator.exe')
41+
$NuGetValidator = [System.IO.Path]::Combine($RepoRoot, 'packages', 'nugetvalidator', '2.0.3', 'tools', 'NuGetValidator.exe')
4242
$LocalizationRepository = [System.IO.Path]::Combine($RepoRoot, 'submodules', 'NuGet.Build.Localization', 'localize', 'comments', '15')
4343

4444
if ($ValidateVsix)

Diff for: ‎setup/Microsoft.VisualStudio.NuGet.BuildTools.swr

-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ folder InstallDir:\Common7\IDE\CommonExtensions\Microsoft\NuGet
88
file source=$(NuGetTargetsBasePath)NuGet.targets
99
file source=$(NuGetTargetsBasePath)NuGet.props
1010
file source=$(NuGetTargetsBasePath)NuGet.RestoreEx.targets
11-
file source=$(ReferenceOutputPath)Microsoft.Extensions.FileProviders.Abstractions.dll
12-
file source=$(ReferenceOutputPath)Microsoft.Extensions.FileSystemGlobbing.dll
13-
file source=$(ReferenceOutputPath)Microsoft.Extensions.Primitives.dll
1411
file source=$(ReferenceOutputPath)Microsoft.Web.XmlTransform.dll
1512
file source=$(ReferenceOutputPath)Microsoft.Build.NuGetSdkResolver.dll
1613
file source=$(NewtonsoftJsonPath)Newtonsoft.Json.dll

Diff for: ‎src/NuGet.Clients/NuGet.CommandLine/ilmerge.props

-7
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="15.0">
33
<ItemGroup>
4-
<MergeInclude Include="$(OutputPath)Microsoft.Extensions.FileProviders.Abstractions.dll"/>
5-
<MergeInclude Include="$(OutputPath)Microsoft.Extensions.FileSystemGlobbing.dll"/>
6-
<MergeInclude Include="$(OutputPath)Microsoft.Extensions.Primitives.dll"/>
74
<MergeInclude Include="$(OutputPath)Microsoft.Web.XmlTransform.dll"/>
85
<MergeInclude Include="$(OutputPath)Newtonsoft.Json.dll"/>
96
<MergeInclude Include="$(OutputPath)NuGet.Build.Tasks.dll"/>
@@ -21,13 +18,11 @@
2118
<MergeInclude Include="$(OutputPath)NuGet.Resolver.dll"/>
2219
<MergeInclude Include="$(OutputPath)NuGet.Versioning.dll"/>
2320
<MergeInclude Include="$(OutputPath)NuGet.Core.dll"/>
24-
<MergeInclude Include="$(OutputPath)System.Memory.dll"/>
2521
<MergeInclude Include="$(OutputPath)System.Threading.Tasks.Dataflow.dll"/>
2622

2723
<MergeExclude Include="$(OutputPath)Microsoft.VisualStudio.Setup.Configuration.Interop.dll"/>
2824
<MergeExclude Include="$(OutputPath)Microsoft.CSharp.dll"/>
2925
<MergeExclude Include="$(OutputPath)mscorlib.dll"/>
30-
<MergeExclude Include="$(OutputPath)System.Buffers.dll"/>
3126
<MergeExclude Include="$(OutputPath)System.Collections.Concurrent.dll"/>
3227
<MergeExclude Include="$(OutputPath)System.Collections.dll"/>
3328
<MergeExclude Include="$(OutputPath)System.ComponentModel.Composition.dll"/>
@@ -37,10 +32,8 @@
3732
<MergeExclude Include="$(OutputPath)System.IO.Compression.dll"/>
3833
<MergeExclude Include="$(OutputPath)System.Net.Http.dll"/>
3934
<MergeExclude Include="$(OutputPath)System.Net.Http.WebRequest.dll"/>
40-
<MergeExclude Include="$(OutputPath)System.Numerics.Vectors.dll"/>
4135
<MergeExclude Include="$(OutputPath)System.Runtime.dll"/>
4236
<MergeExclude Include="$(OutputPath)System.Runtime.Serialization.dll"/>
43-
<MergeExclude Include="$(OutputPath)System.Runtime.CompilerServices.Unsafe.dll"/>
4437
<MergeExclude Include="$(OutputPath)System.Security.dll"/>
4538
<MergeExclude Include="$(OutputPath)System.ServiceModel.dll"/>
4639
<MergeExclude Include="$(OutputPath)System.Xml.dll"/>

Diff for: ‎src/NuGet.Clients/NuGet.MSSigning.Extensions/ilmerge.props

-7
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="15.0">
33
<ItemGroup>
4-
<MergeInclude Include="$(OutputPath)Microsoft.Extensions.FileProviders.Abstractions.dll"/>
5-
<MergeInclude Include="$(OutputPath)Microsoft.Extensions.FileSystemGlobbing.dll"/>
6-
<MergeInclude Include="$(OutputPath)Microsoft.Extensions.Primitives.dll"/>
74
<MergeInclude Include="$(OutputPath)Microsoft.Web.XmlTransform.dll"/>
85
<MergeInclude Include="$(OutputPath)Newtonsoft.Json.dll"/>
96
<MergeInclude Include="$(OutputPath)NuGet.Build.Tasks.dll"/>
@@ -22,13 +19,11 @@
2219
<MergeInclude Include="$(OutputPath)NuGet.Versioning.dll"/>
2320
<MergeInclude Include="$(OutputPath)NuGet.Core.dll"/>
2421
<MergeInclude Include="$(OutputPath)NuGet.MSSigning.Extensions.dll"/>
25-
<MergeInclude Include="$(OutputPath)System.Memory.dll"/>
2622
<MergeInclude Include="$(OutputPath)System.Threading.Tasks.Dataflow.dll"/>
2723

2824
<MergeExclude Include="$(OutputPath)Microsoft.VisualStudio.Setup.Configuration.Interop.dll"/>
2925
<MergeExclude Include="$(OutputPath)Microsoft.CSharp.dll"/>
3026
<MergeExclude Include="$(OutputPath)mscorlib.dll"/>
31-
<MergeExclude Include="$(OutputPath)System.Buffers.dll"/>
3227
<MergeExclude Include="$(OutputPath)System.Collections.Concurrent.dll"/>
3328
<MergeExclude Include="$(OutputPath)System.Collections.dll"/>
3429
<MergeExclude Include="$(OutputPath)System.ComponentModel.Composition.dll"/>
@@ -38,10 +33,8 @@
3833
<MergeExclude Include="$(OutputPath)System.IO.Compression.dll"/>
3934
<MergeExclude Include="$(OutputPath)System.Net.Http.dll"/>
4035
<MergeExclude Include="$(OutputPath)System.Net.Http.WebRequest.dll"/>
41-
<MergeExclude Include="$(OutputPath)System.Numerics.Vectors.dll"/>
4236
<MergeExclude Include="$(OutputPath)System.Runtime.dll"/>
4337
<MergeExclude Include="$(OutputPath)System.Runtime.Serialization.dll"/>
44-
<MergeExclude Include="$(OutputPath)System.Runtime.CompilerServices.Unsafe.dll"/>
4538
<MergeExclude Include="$(OutputPath)System.Security.dll"/>
4639
<MergeExclude Include="$(OutputPath)System.ServiceModel.dll"/>
4740
<MergeExclude Include="$(OutputPath)System.Xml.dll"/>

Diff for: ‎src/NuGet.Clients/NuGet.SolutionRestoreManager/Properties/AssemblyInfo.cs

-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@
2121
[assembly: Guid("06662133-1292-4918-90f3-36c930c0b16f")]
2222

2323
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Lucene.Net.dll")]
24-
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Extensions.FileProviders.Abstractions.dll")]
25-
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Extensions.FileSystemGlobbing.dll")]
26-
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Extensions.Primitives.dll")]
2724
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Newtonsoft.Json.dll")]
2825
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\NuGet.Commands.dll")]
2926
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\NuGet.Common.dll")]

Diff for: ‎src/NuGet.Clients/NuGet.Tools/Properties/AssemblyInfo.cs

-3
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
[assembly: ComVisible(false)]
1212

1313
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Lucene.Net.dll")]
14-
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Extensions.FileProviders.Abstractions.dll")]
15-
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Extensions.FileSystemGlobbing.dll")]
16-
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Extensions.Primitives.dll")]
1714
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Web.XmlTransform.dll")]
1815
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Newtonsoft.Json.dll")]
1916
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\NuGet.Commands.dll")]

Diff for: ‎src/NuGet.Clients/NuGet.VisualStudio.Client/.vsixinclude

-3
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,5 @@ NuGet.Versioning.dll
3434

3535
# 3rd party dlls to keep
3636
Lucene.Net.dll
37-
Microsoft.Extensions.FileProviders.Abstractions.dll
38-
Microsoft.Extensions.FileSystemGlobbing.dll
39-
Microsoft.Extensions.Primitives.dll
4037
Microsoft.Web.XmlTransform.dll
4138
Newtonsoft.Json.dll

Diff for: ‎src/NuGet.Clients/NuGet.VisualStudio.Client/source.extension.vsixmanifest

-3
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,6 @@
6666
<Asset Type="Microsoft.VisualStudio.MefComponent" d:Source="Project" d:ProjectName="NuGet.VisualStudio.OnlineEnvironment.Client" Path="|NuGet.VisualStudio.OnlineEnvironment.Client|" />
6767

6868
<Asset Type="Microsoft.VisualStudio.Assembly" d:Source="File" Path="Lucene.Net.dll" AssemblyName="Lucene.Net, Version=3.0.3.0, Culture=neutral, PublicKeyToken=85089178b9ac3181" />
69-
<Asset Type="Microsoft.VisualStudio.Assembly" d:Source="File" Path="Microsoft.Extensions.FileProviders.Abstractions.dll" AssemblyName="Microsoft.Extensions.FileProviders.Abstractions, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60" />
70-
<Asset Type="Microsoft.VisualStudio.Assembly" d:Source="File" Path="Microsoft.Extensions.FileSystemGlobbing.dll" AssemblyName="Microsoft.Extensions.FileSystemGlobbing, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60" />
71-
<Asset Type="Microsoft.VisualStudio.Assembly" d:Source="File" Path="Microsoft.Extensions.Primitives.dll" AssemblyName="Microsoft.Extensions.Primitives, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60" />
7269
<Asset Type="Microsoft.VisualStudio.Assembly" d:Source="File" Path="Microsoft.Web.XmlTransform.dll" AssemblyName="Microsoft.Web.XmlTransform, Version=2.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
7370
<Asset Type="Microsoft.VisualStudio.Assembly" d:Source="File" Path="Newtonsoft.Json.dll" AssemblyName="Newtonsoft.Json, Version=9.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed" />
7471
</Assets>

Diff for: ‎src/NuGet.Clients/NuGet.VisualStudio.OnlineEnvironment.Client/Properties/AssemblyInfo.cs

-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
[assembly: ComVisible(false)]
1818

1919
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Lucene.Net.dll")]
20-
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Extensions.FileProviders.Abstractions.dll")]
21-
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Extensions.FileSystemGlobbing.dll")]
22-
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Extensions.Primitives.dll")]
2320
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Microsoft.Web.XmlTransform.dll")]
2421
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\Newtonsoft.Json.dll")]
2522
[assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\NuGet.Commands.dll")]

Diff for: ‎src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj

-2
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@
113113
/out:$(PathToMergedNuGetPack) ^
114114
$(ILMergePlatformArg) ^
115115
/lib:$(OutputPath)publish ^
116-
/allowDup ^
117116
/internalize ^
118117
/xmldocs ^
119118
/log:$(ILMergeResultDir)IlMergeLog.txt</IlmergeCommand>
@@ -154,7 +153,6 @@
154153
/out:$(PathToMergedNuGetPackResource) ^
155154
$(ILMergePlatformArg) ^
156155
/log ^
157-
/allowDup ^
158156
/lib:$(OutputPath)\publish ^
159157
/internalize ^
160158
/xmldocs ^

Diff for: ‎src/NuGet.Core/NuGet.CommandLine.XPlat/NuGet.CommandLine.XPlat.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
<ItemGroup>
2121
<PackageReference Include="Microsoft.Extensions.CommandLineUtils.Sources" PrivateAssets="All" />
2222
<PackageReference Include="System.Diagnostics.Debug" />
23-
<PackageReference Include="System.Runtime.Serialization.Primitives" />
2423
</ItemGroup>
2524

2625
<!-- Microsoft.Build.Locator is needed when debugging, but should not be used in the assemblies we insert.

Diff for: ‎src/NuGet.Core/NuGet.Commands/NuGet.Commands.csproj

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project>
1+
<Project>
22
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'NuGet.sln'))\build\common.props" />
33
<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />
44

@@ -22,8 +22,8 @@
2222
</PropertyGroup>
2323

2424
<ItemGroup>
25-
<PackageReference Include="Microsoft.Extensions.FileSystemGlobbing" />
26-
<PackageReference Include="Microsoft.Extensions.FileProviders.Abstractions" />
25+
<Compile Remove="..\..\..\submodules\FileSystem\src\**\AssemblyInfo.cs" />
26+
<Compile Include="..\..\..\submodules\FileSystem\src\Microsoft.Extensions.FileSystemGlobbing\**\*.cs;..\..\..\submodules\FileSystem\src\Microsoft.AspNet.FileProviders.Abstractions\**\*.cs;..\..\..\submodules\FileSystem\src\Microsoft.AspNet.FileProviders.Sources\**\*.cs;..\..\..\submodules\Common\src\Microsoft.Extensions.Primitives\IChangeToken.cs" Exclude="..\..\..\submodules\FileSystem\src\**\AssemblyInfo.cs;bin\**;obj\**;**\*.xproj;packages\**" />
2727
</ItemGroup>
2828

2929
<ItemGroup>

0 commit comments

Comments
 (0)