From 6d2a883676e95a2ee655d807d45f1ed8271fbcb0 Mon Sep 17 00:00:00 2001 From: annguyenNous Date: Sun, 31 May 2026 16:00:35 +0700 Subject: [PATCH] fix(browser): guard module-level int() against non-numeric env var BROWSER_SESSION_INACTIVITY_TIMEOUT was cast via int() at module level without a try/except. Setting BROWSER_INACTIVITY_TIMEOUT to a non-numeric string (e.g. "abc") caused an unhandled ValueError on import, breaking all browser tool functionality. Wrap in try/except (ValueError, TypeError) with fallback to the default of 300 seconds. --- tools/browser_tool.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/browser_tool.py b/tools/browser_tool.py index 482f4e178457c..84ca62f190690 100644 --- a/tools/browser_tool.py +++ b/tools/browser_tool.py @@ -1178,7 +1178,10 @@ def _socket_safe_tmpdir() -> str: # Session inactivity timeout (seconds) - cleanup if no activity for this long # Default: 5 minutes. Needs headroom for LLM reasoning between browser commands, # especially when subagents are doing multi-step browser tasks. -BROWSER_SESSION_INACTIVITY_TIMEOUT = int(os.environ.get("BROWSER_INACTIVITY_TIMEOUT", "300")) +try: + BROWSER_SESSION_INACTIVITY_TIMEOUT = int(os.environ.get("BROWSER_INACTIVITY_TIMEOUT", "300")) +except (ValueError, TypeError): + BROWSER_SESSION_INACTIVITY_TIMEOUT = 300 # Track last activity time per session _session_last_activity: Dict[str, float] = {}