From 037b3fb6cb7cc77fac1a99077fd185039a7cc79d Mon Sep 17 00:00:00 2001
From: Gregory Schlepper <gregluca1969@gmail.com>
Date: Tue, 21 Apr 2026 17:56:37 +0200
Subject: [PATCH] Add configurable models for memory and skill background
 reviews

---
 hermes_cli/config.py | 12 ++++++++
 run_agent.py         | 71 ++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 81 insertions(+), 2 deletions(-)

diff --git a/hermes_cli/config.py b/hermes_cli/config.py
index a87d1d23c93e..6d286ba3aff9 100644
--- a/hermes_cli/config.py
+++ b/hermes_cli/config.py
@@ -697,6 +697,12 @@ def _ensure_hermes_home_managed(home: Path):
         # "hindsight", "holographic", "retaindb", "byterover".
         # Only ONE external provider is allowed at a time.
         "provider": "",
+        "review": {
+            "model": None,
+            "provider": None,
+            "base_url": None,
+            "api_key_env": None,
+        },
     },
 
     # Subagent delegation — override the provider:model used by delegate_task
@@ -738,6 +744,12 @@ def _ensure_hermes_home_managed(home: Path):
         "inline_shell": False,
         # Timeout (seconds) for each !`cmd` snippet when inline_shell is on.
         "inline_shell_timeout": 10,
+        "review": {
+            "model": None,
+            "provider": None,
+            "base_url": None,
+            "api_key_env": None,
+        },
     },
 
     # Honcho AI-native memory -- reads ~/.honcho/config.json as single source of truth.
diff --git a/run_agent.py b/run_agent.py
index c5881b87f6da..2bf542801fa7 100644
--- a/run_agent.py
+++ b/run_agent.py
@@ -2804,15 +2804,82 @@ def _run_review():
             import contextlib
             review_agent = None
             try:
+                try:
+                    from hermes_cli.config import load_config
+
+                    _cfg = load_config()
+                except Exception:
+                    _cfg = {}
+                _mem = _cfg.get("memory") if isinstance(_cfg.get("memory"), dict) else {}
+                _skills_cfg = _cfg.get("skills") if isinstance(_cfg.get("skills"), dict) else {}
+                _mrv = _mem.get("review") if isinstance(_mem.get("review"), dict) else {}
+                _srv = _skills_cfg.get("review") if isinstance(_skills_cfg.get("review"), dict) else {}
+                if review_memory and review_skills:
+                    _rk = "memory+skills"
+                    _blocks = (_mrv, _srv)
+                elif review_memory:
+                    _rk = "memory"
+                    _blocks = (_mrv,)
+                else:
+                    _rk = "skills"
+                    _blocks = (_srv,)
+                eff_model = self.model
+                eff_provider = self.provider
+                eff_base = self.base_url
+                for _b in _blocks:
+                    if not isinstance(_b, dict):
+                        continue
+                    v = _b.get("model")
+                    if v is not None and not (isinstance(v, str) and not v.strip()):
+                        eff_model = v.strip() if isinstance(v, str) else v
+                        break
+                for _b in _blocks:
+                    if not isinstance(_b, dict):
+                        continue
+                    v = _b.get("provider")
+                    if v is not None and not (isinstance(v, str) and not v.strip()):
+                        eff_provider = v.strip() if isinstance(v, str) else v
+                        break
+                for _b in _blocks:
+                    if not isinstance(_b, dict):
+                        continue
+                    v = _b.get("base_url")
+                    if v is not None and not (isinstance(v, str) and not v.strip()):
+                        eff_base = v.strip() if isinstance(v, str) else v
+                        break
+                eff_key = getattr(self, "api_key", None) or ""
+                _key_log = "main"
+                for _b in _blocks:
+                    if not isinstance(_b, dict):
+                        continue
+                    envn = _b.get("api_key_env")
+                    if envn is None or (isinstance(envn, str) and not envn.strip()):
+                        continue
+                    es = envn.strip()
+                    _k = os.environ.get(es, "")
+                    if _k:
+                        eff_key = _k
+                        _key_log = "env:%s" % es
+                        break
+                logger.info(
+                    "Background %s review: model=%r provider=%r base_url=%r api_key=%s",
+                    _rk,
+                    eff_model,
+                    eff_provider,
+                    eff_base,
+                    _key_log,
+                )
                 with open(os.devnull, "w") as _devnull, \
                      contextlib.redirect_stdout(_devnull), \
                      contextlib.redirect_stderr(_devnull):
                     review_agent = AIAgent(
-                        model=self.model,
+                        model=eff_model,
                         max_iterations=8,
                         quiet_mode=True,
                         platform=self.platform,
-                        provider=self.provider,
+                        provider=eff_provider,
+                        base_url=eff_base,
+                        api_key=eff_key,
                     )
                     review_agent._memory_store = self._memory_store
                     review_agent._memory_enabled = self._memory_enabled