fixes for issues encountered with wave/ice coupling#8
Merged
mvertens merged 2 commits intoJul 5, 2023
Merged
Conversation
gold2718
approved these changes
Jul 5, 2023
gold2718
left a comment
There was a problem hiding this comment.
I think it is technically correct although I suggest a few items that would be improvements IMHO.
NickSzapiro-NOAA
added a commit
to NickSzapiro-NOAA/WW3
that referenced
this pull request
Apr 24, 2024
Open
4 tasks
JessicaMeixner-NOAA
pushed a commit
to JessicaMeixner-NOAA/WW3
that referenced
this pull request
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
fixes for issues encountered with wave/ice coupling
Description
This PR provides fixes for #7 and #6.
Issue(s) addressed
#7
#6
Commit Message
fixes for issues encountered with wave/ice coupling
Testing
See #6 for description