Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show better error message when debug_traceTransaction can't re-run unsupported transaction types #597

Closed
fvictorio opened this issue Aug 12, 2024 · 0 comments · Fixed by #606
Assignees

Comments

@fvictorio
Copy link
Member

Hardhat doesn't support using debug_traceTransaction with blocks that contain unsupported transaction types before the given transaction. This was already the case in pre-EDR Hardhat, but at least the error message was better:

Uncaught InternalError: Only legacy, EIP2930, and EIP1559 txs are supported

Which is not great, but it's better than what HH+EDR does:

thread 'tokio-runtime-worker' panicked at /build/crates/edr_evm/src/transaction.rs:55:18:
internal error: entered unreachable code: error: Header(ExcessBlobGasNotSet)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Uncaught [Error: task 433 panicked] { code: 'GenericFailure' }

We should detect this situation an throw a better error. The error message can be something like:

`debug_traceTransaction` cannot be used with transaction "<txHash>", because its block includes transaction "<unsupportedTransactionHash>" with the unsupported type "<unsupportedTransactionType>"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants