Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #25

Open
Inglan opened this issue Oct 28, 2024 · 11 comments
Open

Add CI #25

Inglan opened this issue Oct 28, 2024 · 11 comments
Assignees
Labels
enhancement A new feature or request low priority

Comments

@Inglan
Copy link
Member

Inglan commented Oct 28, 2024

Is your enhancement related to a problem? Please describe.

no

Describe the solution you'd like

Using CI to build versions for all OSes

Describe alternatives you've considered

You already build on your machine and release

Additional context

I can open a PR to add this

@Inglan Inglan added the enhancement A new feature or request label Oct 28, 2024
@sebashtioon
Copy link
Member

sebashtioon commented Oct 29, 2024

Hmm, I have no idea how this would work though, how would I/you do this?
I'm thinking maybe a ci.yml file in the .github/workflows folder.

@Inglan
Copy link
Member Author

Inglan commented Oct 29, 2024

Doesn't seem to work. I started a build in my own fork and never finished

@sebashtioon sebashtioon reopened this Oct 29, 2024
@sebashtioon
Copy link
Member

Doesn't seem to work. I started a build in my own fork and never finished

Yeah mine too

@sebashtioon
Copy link
Member

Just saw ur recent commits on the forked repo, does it work now? Can I create a pull req?

@sebashtioon sebashtioon added this to the v0.5.0 milestone Oct 31, 2024
@Inglan
Copy link
Member Author

Inglan commented Oct 31, 2024

Just saw ur recent commits on the forked repo, does it work now? Can I create a pull req?

Don't think so. Don't create a pr yet

@sebashtioon
Copy link
Member

Just saw ur recent commits on the forked repo, does it work now? Can I create a pull req?

Don't think so. Don't create a pr yet

Okay

@sebashtioon sebashtioon removed this from the v0.5.0 milestone Nov 11, 2024
@Inglan
Copy link
Member Author

Inglan commented Nov 23, 2024

I will look into this and reopen if I work it out

@Inglan Inglan closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2024
@Inglan
Copy link
Member Author

Inglan commented Jan 1, 2025

Ok, I worked this out so I will implement when I have the time

Here's the workflow I used: https://github.com/Inglan/MemoryOverflow/blob/main/.github/workflows/build.yml

@Inglan Inglan reopened this Jan 1, 2025
@sebashtioon
Copy link
Member

Thank you! Will not be able to review until 5th of January anyway. Happy new year

@Inglan
Copy link
Member Author

Inglan commented Jan 2, 2025

Just tried to implement in a fork, but running into the same issue as before, where it hangs. Not sure why, as it worked on my game. I will look into this later.

@sebashtioon
Copy link
Member

Alright sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or request low priority
Projects
None yet
Development

No branches or pull requests

2 participants