View bobbing abruptly moving to default camera pos fixed.

Author: sebashtioon

Game Assets/Player/3DPlayer.tscn

@@ -1,19 +1,17 @@
-[gd_scene load_steps=7 format=3 uid="uid://bsljbif1rji7e"]
+[gd_scene load_steps=5 format=3 uid="uid://bsljbif1rji7e"]
 
 [ext_resource type="Script" path="res://Game Assets/Player/3DPlayer_SCRIPT.gd" id="1_dbfha"]
-[ext_resource type="Script" path="res://Textures/Icons/Script Icons/Scripts/CameraIcon_SCRIPT.gd" id="2_ef18p"]
 [ext_resource type="Texture2D" uid="uid://tmqrfb1atg1j" path="res://Textures/Crosshairs/Expland_Crosshair.png" id="5_due8n"]
-[ext_resource type="Script" path="res://Scenes and Scripts/Scenes/Player/CrosshairCanvas/Crosshair_SCRIPT.gd" id="6_01j83"]
 
 [sub_resource type="CapsuleMesh" id="CapsuleMesh_e8ep2"]
 
 [sub_resource type="ConvexPolygonShape3D" id="ConvexPolygonShape3D_ocuv0"]
 points = PackedVector3Array(-0.125207, -0.532801, -0.480507, 0.0227831, 0.47607, 0.498884, 0.169713, 0.559144, 0.464172, 0.231051, -0.803591, 0.320455, 0.40741, 0.651043, -0.243523, -0.482789, 0.594843, 0.0822132, -0.362868, -0.682312, 0.289697, 0.469044, -0.654529, -0.0662713, -0.127444, 0.842701, -0.338103, -0.393435, -0.683942, -0.244717, 0.438255, 0.623309, 0.200849, 0.0841477, 0.977454, 0.114795, -0.0682023, -0.976458, -0.12927, 0.20055, -0.563129, -0.451454, -0.185527, 0.595453, -0.453475, -0.273363, 0.592268, 0.407754, -0.00693649, -0.476823, 0.49966, 0.375821, -0.588614, 0.316955, 0.111579, 0.563059, -0.481177, -0.41725, 0.527866, -0.270497, -0.484546, -0.596972, -0.0665097, -0.279747, 0.908561, 0.0533361, -0.250197, -0.880712, 0.205319, 0.263647, -0.902771, -0.127394, 0.293368, 0.871526, -0.157196, 0.373412, -0.526319, -0.328246, 0.499663, 0.476641, -0.00688856, 0.0531056, 0.875001, 0.324703, -0.154543, -0.590854, 0.465879, -0.0972799, -0.782358, -0.398188, -0.387649, -0.498171, 0.31565, -0.30068, -0.587995, -0.388901)
 
-[node name="Player" type="CharacterBody3D"]
+[node name="3DPlayer" type="CharacterBody3D"]
 script = ExtResource("1_dbfha")
 
-[node name="MeshInstance3D" type="MeshInstance3D" parent="."]
+[node name="Body" type="MeshInstance3D" parent="."]
 transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 1, 0)
 mesh = SubResource("CapsuleMesh_e8ep2")
 
@@ -25,7 +23,6 @@ shape = SubResource("ConvexPolygonShape3D_ocuv0")
 transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 1.66439, 0)
 
 [node name="Camera3D" type="Camera3D" parent="Head"]
-script = ExtResource("2_ef18p")
 
 [node name="CrosshairCanvas" type="CanvasLayer" parent="Head/Camera3D"]
 
@@ -40,5 +37,4 @@ grow_horizontal = 2
 grow_vertical = 2
 texture = ExtResource("5_due8n")
 expand_mode = 1
-script = ExtResource("6_01j83")
 metadata/_edit_use_anchors_ = true

Game Assets/Player/3DPlayer_SCRIPT.gd

@@ -40,6 +40,7 @@ extends CharacterBody3D # Inheritance
 
 @export var BOB_FREQ := 3.0 # The frequency of the waves (how often it occurs)
 @export var BOB_AMP = 0.08 # The amplitude of the waves (how much you actually go up and down)
+@export var BOB_SMOOTHING_SPEED := 3.0  # Speed to smooth the return to the original position. The lower it get's, the smoother it is.
 
 @export_subgroup("Other") # a subgroup for other view bobbing variables.
 @export var Wave_Length = 0.0 # The wavelength of the bobbing
@@ -82,6 +83,7 @@ func _unhandled_input(event):
 #~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
 #~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
 #~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
+# Modify _physics_process to include smooth transition when not moving
 func _physics_process(delta):
 	# Always apply gravity regardless of the game state
 	if not is_on_floor():
@@ -90,51 +92,50 @@ func _physics_process(delta):
 	# Jumping
 	if Input.is_action_just_pressed("Jump") and is_on_floor():
 		velocity.y = JUMP_VELOCITY
-	
+
 	# Sprinting
-	if Input.is_action_pressed("Sprint"):
-		speed = SPRINT_SPEED
-	else:
-		speed = WALK_SPEED
-	
+	speed = SPRINT_SPEED if Input.is_action_pressed("Sprint") else WALK_SPEED
+
 	# Movement
 	var input_dir = Input.get_vector("move_left", "move_right", "move_forward", "move_backward")
 	var direction = (head.transform.basis * Vector3(input_dir.x, 0, input_dir.y)).normalized()
+
 	if is_on_floor():
-		if direction:
+		if direction != Vector3.ZERO:
 			velocity.x = direction.x * speed
 			velocity.z = direction.z * speed
 		else:
-			velocity.x = lerp(velocity.x, float(direction.x) * speed, delta * 10.0)
-			velocity.z = lerp(velocity.z, float(direction.z) * speed, delta * 10.0)
+			velocity.x = lerp(velocity.x, 0.0, delta * 10.0)
+			velocity.z = lerp(velocity.z, 0.0, delta * 10.0)
 	else:
-		velocity.x = lerp(velocity.x, float(direction.x) * speed, delta * 3.0)
-		velocity.z = lerp(velocity.z, float(direction.z) * speed, delta * 3.0)
-	
-	
+		velocity.x = lerp(velocity.x, direction.x * speed, delta * 3.0)
+		velocity.z = lerp(velocity.z, direction.z * speed, delta * 3.0)
+
 	move_and_slide()
-	# Check if the player is moving (i.e., not just stopped by a collision) and on the floor
+
+	# Check if the player is moving and on the floor
 	var is_moving = velocity.length() > 0.1 and is_on_floor()
-	
+
 	# Apply view bobbing only if the player is moving
 	if is_moving:
 		Wave_Length += delta * velocity.length()
 		camera.transform.origin = _headbob(Wave_Length)
 	else:
-		camera.transform.origin.y = 0  # Reset bobbing when not moving
+		# Smoothly return to original position when not moving
+		var target_pos = Vector3(camera.transform.origin.x, 0, camera.transform.origin.z)
+		camera.transform.origin = camera.transform.origin.lerp(target_pos, delta * BOB_SMOOTHING_SPEED)
 
-func _process(_delta):
-	
-	if FOV == 9999:
-		$Head/Camera3D.fov = PlayerSettingsData.FOV
-	else:
-		$Head/Camera3D.fov = FOV
-	
-	$Head/Camera3D/CrosshairCanvas/Crosshair.size = crosshair_size
+# The headbob function remains the same
 func _headbob(time) -> Vector3:
 	var pos = Vector3.ZERO
 	pos.y = sin(time * BOB_FREQ) * BOB_AMP
 	return pos
+func _process(_delta):
+	
+	$Head/Camera3D.fov = FOV
+	
+	$Head/Camera3D/CrosshairCanvas/Crosshair.size = crosshair_size
+
 
 #~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
 #~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#

Scenes and Scripts/Scenes/Player/Player_SCRIPT.gd

@@ -51,6 +51,7 @@ The keyword @export means that they can be accessed in the inspector panel (righ
 
 @export var BOB_FREQ := 3.0 # The frequency of the waves (how often it occurs)
 @export var BOB_AMP = 0.08 # The amplitude of the waves (how much you actually go up and down)
+@export var BOB_SMOOTHING_SPEED := 3.0  # Speed to smooth the return to the original position. The lower it get's, the smoother it is.
 
 @export_subgroup("Other") # a subgroup for other view bobbing variables.
 @export var Wave_Length = 0.0 # The wavelength of the bobbing
@@ -174,7 +175,6 @@ func _physics_process(delta):
 
 	# Handle movement restrictions when the inventory is open
 	if GAME_STATE == "INVENTORY":
-		# If the player is on the ground when the inventory is opened or lands, stop movement
 		if is_on_floor():
 			velocity.x = 0
 			velocity.z = 0
@@ -185,38 +185,44 @@ func _physics_process(delta):
 	# Jumping
 	if Input.is_action_just_pressed("Jump") and is_on_floor():
 		velocity.y = JUMP_VELOCITY
-	
+
 	# Sprinting
-	if Input.is_action_pressed("Sprint"):
-		speed = SPRINT_SPEED
-	else:
-		speed = WALK_SPEED
-	
+	speed = SPRINT_SPEED if Input.is_action_pressed("Sprint") else WALK_SPEED
+
 	# Movement
 	var input_dir = Input.get_vector("move_left", "move_right", "move_forward", "move_backward")
 	var direction = (head.transform.basis * Vector3(input_dir.x, 0, input_dir.y)).normalized()
+
 	if is_on_floor():
-		if direction:
+		if direction != Vector3.ZERO:
 			velocity.x = direction.x * speed
 			velocity.z = direction.z * speed
 		else:
-			velocity.x = lerp(velocity.x, float(direction.x) * speed, delta * 10.0)
-			velocity.z = lerp(velocity.z, float(direction.z) * speed, delta * 10.0)
+			velocity.x = lerp(velocity.x, 0.0, delta * 10.0)
+			velocity.z = lerp(velocity.z, 0.0, delta * 10.0)
 	else:
-		velocity.x = lerp(velocity.x, float(direction.x) * speed, delta * 3.0)
-		velocity.z = lerp(velocity.z, float(direction.z) * speed, delta * 3.0)
-	
-	
+		velocity.x = lerp(velocity.x, direction.x * speed, delta * 3.0)
+		velocity.z = lerp(velocity.z, direction.z * speed, delta * 3.0)
+
 	move_and_slide()
-	# Check if the player is moving (i.e., not just stopped by a collision) and on the floor
+
+	# Check if the player is moving and on the floor
 	var is_moving = velocity.length() > 0.1 and is_on_floor()
-	
+
 	# Apply view bobbing only if the player is moving
 	if is_moving:
 		Wave_Length += delta * velocity.length()
 		camera.transform.origin = _headbob(Wave_Length)
 	else:
-		camera.transform.origin.y = 0  # Reset bobbing when not moving
+		# Smoothly return to original position when not moving
+		var target_pos = Vector3(camera.transform.origin.x, 0, camera.transform.origin.z)
+		camera.transform.origin = camera.transform.origin.lerp(target_pos, delta * BOB_SMOOTHING_SPEED)
+
+# The headbob function remains the same
+func _headbob(time) -> Vector3:
+	var pos = Vector3.ZERO
+	pos.y = sin(time * BOB_FREQ) * BOB_AMP
+	return pos
 func _process(_delta):
 
 	if UseHealth == false:
@@ -234,10 +240,7 @@ func _process(_delta):
 		$Head/Camera3D.fov = FOV
 
 	$Head/Camera3D/CrosshairCanvas/Crosshair.size = crosshair_size
-func _headbob(time) -> Vector3:
-	var pos = Vector3.ZERO
-	pos.y = sin(time * BOB_FREQ) * BOB_AMP
-	return pos
+
 
 #~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
 #~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#

Scenes and Scripts/Scenes/Tests/test.tscn

@@ -1,6 +1,6 @@
 [gd_scene load_steps=5 format=3 uid="uid://clqkg5xb8eu01"]
 
-[ext_resource type="PackedScene" uid="uid://bsljbif1rji7e" path="res://Game Assets/Player/3DPlayer.tscn" id="1_5eu0s"]
+[ext_resource type="PackedScene" uid="uid://dlbkch6iuy8gn" path="res://Godot_First-Person-Controller-7310c731306fc98c7209fb28666ea85523cf86f5/addons/fp_controller/player.tscn" id="1_86eax"]
 
 [sub_resource type="ProceduralSkyMaterial" id="ProceduralSkyMaterial_csbo8"]
 sky_horizon_color = Color(0.64625, 0.65575, 0.67075, 1)
@@ -29,5 +29,5 @@ transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 0.0912914, 0.0251261, -1.6345
 use_collision = true
 size = Vector3(17.249, 1, 21.6737)
 
-[node name="Player" parent="." instance=ExtResource("1_5eu0s")]
-transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 0.805227, 0.602243, 0.472525)
+[node name="Player" parent="." instance=ExtResource("1_86eax")]
+transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 1, 0)

player.dat

@@ -1 +1 @@
-{"GAME_STATE":"NORMAL","Health":100,"Position":{"x":-34.737117767334,"y":24.3865070343018,"z":29.1238059997559}}
+{"GAME_STATE":"NORMAL","Health":100,"Position":{"x":-22.5039043426514,"y":24.8419246673584,"z":11.2414655685425}}