Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of posts #4

Open
piranna opened this issue Mar 12, 2015 · 8 comments
Open

Order of posts #4

piranna opened this issue Mar 12, 2015 · 8 comments

Comments

@piranna
Copy link
Member

piranna commented Mar 12, 2015

Posts are sorted by reverse lexicographical order... so issue 117 is showed after 19 and 17 :-P Issue ID should be identified as a number.

@piranna
Copy link
Member Author

piranna commented Mar 22, 2015

Seems it has magically fixed itself... or it was a problem of cache :-P Closing.

@piranna piranna closed this as completed Mar 22, 2015
@piranna
Copy link
Member Author

piranna commented Mar 22, 2015

The problem, has appeared again, seems it's related to the localstorage since the new posts are the one that appear at the bootm, so I'll reopen it. @formula1, could you be able to review it?

@piranna piranna reopened this Mar 22, 2015
@formula1
Copy link

I believe it is in part associated to

I'll try to solve this right now as well as add a simple version control system. aka

  • server will also send the version number
  • if the version number > the users version number, clear the cache

@formula1
Copy link

I was able to reproduce the issue with the following

localStorage.setItem("issue-list",
  JSON.stringify(
    JSON.parse(
      localStorage.getItem(
        "issue-list"
      )
    ).slice(1)
  )
);

just fixed it and also realized that there are definietly some issues with the user-provider which I'm about to handle

@formula1
Copy link

I fixed the problem from before with auth provider, but a new one showed up, I was attempting to write an encoder from hand but everything is simple in theory...........

I have to go at the moment, but what will end up happening is a complete avoidence of querystring all togethor.

@formula1
Copy link

It should be working properly: https://github.com/formula1/NodeOS-Blog

I'm currently in the process of merging with this repo

@piranna
Copy link
Member Author

piranna commented Mar 26, 2015

I'll try to solve this right now as well as add a simple version control system. aka

server will also send the version number
if the version number > the users version number, clear the cache

Could you be able to explain this? GitHub metadata should be enough... isn't it?

@formula1
Copy link

Essentially, if we are storing things incorrectly or make changes how we store, I am clearing the cache. It's based off what we are doing more than what github is doing. If github's api changes, we'd likely have to reset the cache. If we make changes, we'd likely have to reset the cache

https://github.com/NodeOS/GitBlog/pull/6/files#diff-8920948fe65b76cfdda1a5fe940b4ce7R2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants