diff --git a/ofborg/src/tasks/eval/mod.rs b/ofborg/src/tasks/eval/mod.rs index 7976fd02..06f14fd2 100644 --- a/ofborg/src/tasks/eval/mod.rs +++ b/ofborg/src/tasks/eval/mod.rs @@ -13,7 +13,6 @@ pub trait EvaluationStrategy { fn on_target_branch(&mut self, co: &Path, status: &mut CommitStatus) -> StepResult<()>; fn after_fetch(&mut self, co: &CachedProjectCo) -> StepResult<()>; - fn merge_conflict(&mut self); fn after_merge(&mut self, status: &mut CommitStatus) -> StepResult<()>; fn evaluation_checks(&self) -> Vec; fn all_evaluations_passed( diff --git a/ofborg/src/tasks/eval/nixpkgs.rs b/ofborg/src/tasks/eval/nixpkgs.rs index 1f4ce22e..54c5c67c 100644 --- a/ofborg/src/tasks/eval/nixpkgs.rs +++ b/ofborg/src/tasks/eval/nixpkgs.rs @@ -128,21 +128,7 @@ impl<'a> EvaluationStrategy for NixpkgsStrategy<'a> { Ok(()) } - fn merge_conflict(&mut self) { - update_labels( - self.issue_ref, - &["2.status: merge conflict".to_owned()], - &[], - ); - } - fn after_merge(&mut self, status: &mut CommitStatus) -> StepResult<()> { - update_labels( - self.issue_ref, - &[], - &["2.status: merge conflict".to_owned()], - ); - status.set_with_description("Checking new out paths", hubcaps::statuses::State::Pending)?; self.check_outpaths_after()?; diff --git a/ofborg/src/tasks/evaluate.rs b/ofborg/src/tasks/evaluate.rs index 8b67c6d2..969ed4f3 100644 --- a/ofborg/src/tasks/evaluate.rs +++ b/ofborg/src/tasks/evaluate.rs @@ -355,8 +355,6 @@ impl<'a, E: stats::SysEvents + 'static> OneEval<'a, E> { info!("Failed to merge {}", job.pr.head_sha); - evaluation_strategy.merge_conflict(); - return Ok(self.actions().skip(job)); }