unstableGitUpdater: pass --print-changes to update-source-version#490004
Merged
Conversation
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
jtojnar
reviewed
Feb 13, 2026
This enables git commit message customization when writing a thin-wrapper around unstableGitUpdater with "commit" in supportedFeatures. Passing --print-changes unconditionally is consistent with other updaters such as genericUpdater, which is used by many updaters. We also redirect all non-json stdout to stderr so that the whole stdout contains a valid json.
jian-lin
force-pushed
the
pr/unstableGitUpdater-commit
branch
from
d23af0c to
ca16356
Compare
Contributor
Author
|
ping :) |
Contributor
Author
|
I plan to merge this in a few days if no more review. |
nixpkgs-ci
Bot
added
the
12.approvals: 1
Contributor
Author
|
Thanks for all your review! |
adamcstephens
pushed a commit
to adamcstephens/nixpkgs
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables git commit message customization when writing a thin-wrapper around unstableGitUpdater with "commit" in supportedFeatures.
Passing --print-changes unconditionally is consistent with other updaters such as genericUpdater, which is used by many updaters.
We also redirect all non-json stdout to stderr so that the whole
stdout contains a valid json.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.