From fe1a3f1631d7e1ee06deabe06710421ea3bf2bec Mon Sep 17 00:00:00 2001 From: Aliaksandr Date: Tue, 10 Feb 2026 02:58:40 +0200 Subject: [PATCH 1/4] gopro-tool: move overrides to package.nix --- pkgs/by-name/go/gopro-tool/package.nix | 6 +++++- pkgs/top-level/all-packages.nix | 6 ------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/pkgs/by-name/go/gopro-tool/package.nix b/pkgs/by-name/go/gopro-tool/package.nix index a5b848d28b5d2..460b498dd2bcf 100644 --- a/pkgs/by-name/go/gopro-tool/package.nix +++ b/pkgs/by-name/go/gopro-tool/package.nix @@ -5,7 +5,11 @@ makeWrapper, ffmpeg, vlc, + vlc' ? vlc.overrideAttrs (old: { + buildInputs = old.buildInputs ++ [ x264 ]; + }), jq, + x264, }: stdenv.mkDerivation { @@ -30,7 +34,7 @@ stdenv.mkDerivation { --prefix PATH : ${ lib.makeBinPath [ ffmpeg - vlc + vlc' jq ] } diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index fa357ead5f9bc..ebd26f56c63e4 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -4528,12 +4528,6 @@ with pkgs; dotnetPackages = recurseIntoAttrs (callPackage ./dotnet-packages.nix { }); - gopro-tool = callPackage ../by-name/go/gopro-tool/package.nix { - vlc = vlc.overrideAttrs (old: { - buildInputs = old.buildInputs ++ [ x264 ]; - }); - }; - gwe = callPackage ../tools/misc/gwe { nvidia_x11 = linuxPackages.nvidia_x11; }; From eb955cdba5981d6d121c4ed47f7a56080ab8c324 Mon Sep 17 00:00:00 2001 From: Aliaksandr Date: Tue, 10 Feb 2026 02:58:57 +0200 Subject: [PATCH 2/4] gopro-tool: enable strictDeps and structuredAttrs --- pkgs/by-name/go/gopro-tool/package.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/by-name/go/gopro-tool/package.nix b/pkgs/by-name/go/gopro-tool/package.nix index 460b498dd2bcf..e7b53ca984c90 100644 --- a/pkgs/by-name/go/gopro-tool/package.nix +++ b/pkgs/by-name/go/gopro-tool/package.nix @@ -25,6 +25,9 @@ stdenv.mkDerivation { nativeBuildInputs = [ makeWrapper ]; + strictDeps = true; + __structuredAttrs = true; + installPhase = '' mkdir -p $out/bin cp $src/gopro-tool $out/bin/gopro-tool From db5fa7acafcbe7835f10ffcac683fab888cedf52 Mon Sep 17 00:00:00 2001 From: Aliaksandr Date: Tue, 10 Feb 2026 02:59:14 +0200 Subject: [PATCH 3/4] gopro-tool: add passthru.tests --- pkgs/by-name/go/gopro-tool/package.nix | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkgs/by-name/go/gopro-tool/package.nix b/pkgs/by-name/go/gopro-tool/package.nix index e7b53ca984c90..8f9f7306300d9 100644 --- a/pkgs/by-name/go/gopro-tool/package.nix +++ b/pkgs/by-name/go/gopro-tool/package.nix @@ -10,6 +10,7 @@ }), jq, x264, + nixosTests, }: stdenv.mkDerivation { @@ -43,6 +44,10 @@ stdenv.mkDerivation { } ''; + passthru.tests = { + inherit (nixosTests) gopro-tool; + }; + meta = { description = "Tool to control GoPro webcam mode in Linux (requires v4l2loopback kernel module and a firewall rule)"; license = lib.licenses.bsd3; From 662fd4baf42ff3ffe1fb8d61abcad16bb7e6d661 Mon Sep 17 00:00:00 2001 From: Aliaksandr Date: Tue, 10 Feb 2026 02:59:31 +0200 Subject: [PATCH 4/4] gopro-tool: 0-unstable-2024-04-18 -> 1.18 --- pkgs/by-name/go/gopro-tool/package.nix | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/go/gopro-tool/package.nix b/pkgs/by-name/go/gopro-tool/package.nix index 8f9f7306300d9..475d2df020671 100644 --- a/pkgs/by-name/go/gopro-tool/package.nix +++ b/pkgs/by-name/go/gopro-tool/package.nix @@ -13,15 +13,15 @@ nixosTests, }: -stdenv.mkDerivation { +stdenv.mkDerivation (finalAttrs: { pname = "gopro-tool"; - version = "0-unstable-2024-04-18"; + version = "1.18"; src = fetchFromGitHub { owner = "juchem"; repo = "gopro-tool"; - rev = "a678f0ea65e24dca9b8d848b245bd2d487d3c8ca"; - sha256 = "0sh3s38m17pci24x4kdlmlhn0gwgm28aaa6p7qs16wysk0q0h6wz"; + tag = "v${finalAttrs.version}"; + hash = "sha256-nxsIMJjacxM0PtcopZCojz9gIa20TdKJiOyeUNHQA2o="; }; nativeBuildInputs = [ makeWrapper ]; @@ -54,4 +54,4 @@ stdenv.mkDerivation { maintainers = with lib.maintainers; [ ZMon3y ]; platforms = lib.platforms.linux; }; -} +})