From 43d5f641ee03025c3790e06d022304c8ea623bb2 Mon Sep 17 00:00:00 2001
From: Isidor Zeuner <nix@quidecco.pl>
Date: Wed, 27 Aug 2025 07:32:12 +0200
Subject: [PATCH] ci/eval/compare: avoid CI failures on non-github maintainer
 records

---
 ci/eval/compare/maintainers.nix | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/ci/eval/compare/maintainers.nix b/ci/eval/compare/maintainers.nix
index 43ae050acba4f..c33e9d03aca08 100644
--- a/ci/eval/compare/maintainers.nix
+++ b/ci/eval/compare/maintainers.nix
@@ -95,14 +95,20 @@ let
 
   attrsWithModifiedFiles = builtins.filter (pkg: anyMatchingFiles pkg.filenames) attrsWithFilenames;
 
+  # TODO: create ping lists for other contacts once non-GitHub ping
+  #  implementations get merged
   listToPing = lib.concatMap (
     pkg:
-    builtins.map (maintainer: {
-      id = maintainer.githubId;
-      inherit (maintainer) github;
-      packageName = pkg.name;
-      dueToFiles = pkg.filenames;
-    }) pkg.maintainers
+    builtins.map
+      (maintainer: {
+        id = maintainer.githubId;
+        inherit (maintainer) github;
+        packageName = pkg.name;
+        dueToFiles = pkg.filenames;
+      })
+      # TODO: If community consensus (e.g. an RFC) makes `githubId` mandatory,
+      #  simplify to `pkg.maintainers`
+      (builtins.filter (maintainer: maintainer ? githubId) pkg.maintainers)
   ) attrsWithModifiedFiles;
 
   byMaintainer = lib.groupBy (ping: toString ping.${if byName then "github" else "id"}) listToPing;