From 1879229cf0949104f7f3a3ac022f909a4b182368 Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Fri, 27 Jun 2025 14:41:27 +0200 Subject: [PATCH] gnum4: unconditionally disable format hardening :( --- pkgs/by-name/gn/gnum4/package.nix | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/gn/gnum4/package.nix b/pkgs/by-name/gn/gnum4/package.nix index 61c9b85c2b3da..4a096c117ec57 100644 --- a/pkgs/by-name/gn/gnum4/package.nix +++ b/pkgs/by-name/gn/gnum4/package.nix @@ -33,9 +33,10 @@ stdenv.mkDerivation (finalAttrs: { enableParallelBuilding = true; - # Without the change the build fails on Darwin as https://hydra.nixos.org/build/300264726/nixlog/3/tail: - # clean-temp.c:235:14: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] - hardeningDisable = lib.optionals stdenv.hostPlatform.isDarwin [ "format" ]; + # Issue exists whenever NLS is disabled, and there's an upstream fix + # for GCC, but there's no good way to check whether NLS or GCC is in + # use. (Checking stdenv.cc.isGNU causes infinite recursion.) + hardeningDisable = [ "format" ]; doCheck = false;