Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zotero: init darwin #351227

Merged
merged 1 commit into from
Oct 30, 2024
Merged

zotero: init darwin #351227

merged 1 commit into from
Oct 30, 2024

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Oct 25, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Whoops, I didn't see that #343384 and #248092 already existed...

Closes #343384 and #248092

cc @sstubbs @klchen0112

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Oct 25, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 25, 2024
@sstubbs
Copy link
Contributor

sstubbs commented Oct 29, 2024

Great this is being done. Not sure why the tests never ran for my PR.

@NickHu NickHu merged commit 05e3b3d into NixOS:master Oct 30, 2024
33 checks passed
@NickHu NickHu deleted the zotero-darwin branch October 30, 2024 17:18
keatonhasse pushed a commit to keatonhasse/nixpkgs that referenced this pull request Oct 30, 2024
@NickHu @keatonhasse
zotero: init darwin (NixOS#351227)
c130229
@phanirithvij phanirithvij mentioned this pull request Oct 31, 2024
Merged
2 tasks
frederictobiasc pushed a commit to frederictobiasc/nixpkgs that referenced this pull request Nov 9, 2024
@NickHu @frederictobiasc
zotero: init darwin (NixOS#351227)
5051cab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justanotherariel justanotherariel Awaiting requested review from justanotherariel

@AtilaSaraiva AtilaSaraiva Awaiting requested review from AtilaSaraiva

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickHu @sstubbs