From b10dfee516d7a5a72292a412f10aaecb5448599b Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Tue, 3 Sep 2024 14:11:53 -0300 Subject: [PATCH 01/14] SDL_compat: copy setup-hook.sh from SDL_classic --- .../development/libraries/SDL_compat/default.nix | 2 +- .../libraries/SDL_compat/setup-hook.sh | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 pkgs/development/libraries/SDL_compat/setup-hook.sh diff --git a/pkgs/development/libraries/SDL_compat/default.nix b/pkgs/development/libraries/SDL_compat/default.nix index 4a5d54df0e3dc..dbe720837afaf 100644 --- a/pkgs/development/libraries/SDL_compat/default.nix +++ b/pkgs/development/libraries/SDL_compat/default.nix @@ -37,7 +37,7 @@ stdenv.mkDerivation rec { enableParallelBuilding = true; - setupHook = ../SDL/setup-hook.sh; + setupHook = ./setup-hook.sh; postFixup = '' for lib in $out/lib/*${stdenv.hostPlatform.extensions.sharedLibrary}* ; do diff --git a/pkgs/development/libraries/SDL_compat/setup-hook.sh b/pkgs/development/libraries/SDL_compat/setup-hook.sh new file mode 100644 index 0000000000000..54a9b3e8bfab4 --- /dev/null +++ b/pkgs/development/libraries/SDL_compat/setup-hook.sh @@ -0,0 +1,16 @@ +addSDLPath () { + if [ -e "$1/include/SDL" ]; then + export SDL_PATH="${SDL_PATH-}${SDL_PATH:+ }$1/include/SDL" + # NB this doesn’t work with split dev packages because different packages + # will contain "include/SDL/" and "lib/" directories. + # + # However the SDL_LIB_PATH is consumed by SDL itself and serves to locate + # libraries like SDL_mixer, SDL_image, etc which are not split-package + # so the check above will only trigger on them. + if [ -e "$1/lib" ]; then + export SDL_LIB_PATH="${SDL_LIB_PATH-}${SDL_LIB_PATH:+ }-L$1/lib" + fi + fi +} + +addEnvHooks "$hostOffset" addSDLPath From 1918269b08b5605ec23577a662bbb3ad3f4a30db Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Tue, 3 Sep 2024 14:22:16 -0300 Subject: [PATCH 02/14] SDL_compat: hide parameters under package expression --- pkgs/development/libraries/SDL_compat/default.nix | 6 +++--- pkgs/top-level/all-packages.nix | 5 +---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/pkgs/development/libraries/SDL_compat/default.nix b/pkgs/development/libraries/SDL_compat/default.nix index dbe720837afaf..a5f3d6360f892 100644 --- a/pkgs/development/libraries/SDL_compat/default.nix +++ b/pkgs/development/libraries/SDL_compat/default.nix @@ -5,17 +5,17 @@ , pkg-config , SDL2 , libiconv -, Cocoa -, autoSignDarwinBinariesHook , mesa , libGLSupported ? lib.elem stdenv.hostPlatform.system mesa.meta.platforms , openglSupport ? libGLSupported , libGLU +, darwin }: let inherit (lib) optionals makeLibraryPath; - + inherit (darwin.apple_sdk.frameworks) Cocoa; + inherit (darwin) autoSignDarwinBinariesHook; in stdenv.mkDerivation rec { pname = "SDL_compat"; diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index b5ebfb6ac4cba..d0cbfba5ab7ad 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -23454,10 +23454,7 @@ with pkgs; libGLU = null; }); - SDL_compat = callPackage ../development/libraries/SDL_compat { - inherit (darwin.apple_sdk.frameworks) Cocoa; - inherit (darwin) autoSignDarwinBinariesHook; - }; + SDL_compat = callPackage ../development/libraries/SDL_compat { }; SDL = SDL_classic; From 77b1cefe321e18a15032ff4597b474282894ae21 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Wed, 4 Sep 2024 12:20:35 -0300 Subject: [PATCH 03/14] SDL_compat: migrate to by-name --- .../default.nix => by-name/sd/SDL_compat/package.nix} | 0 .../libraries => by-name/sd}/SDL_compat/setup-hook.sh | 0 pkgs/top-level/all-packages.nix | 2 -- 3 files changed, 2 deletions(-) rename pkgs/{development/libraries/SDL_compat/default.nix => by-name/sd/SDL_compat/package.nix} (100%) rename pkgs/{development/libraries => by-name/sd}/SDL_compat/setup-hook.sh (100%) diff --git a/pkgs/development/libraries/SDL_compat/default.nix b/pkgs/by-name/sd/SDL_compat/package.nix similarity index 100% rename from pkgs/development/libraries/SDL_compat/default.nix rename to pkgs/by-name/sd/SDL_compat/package.nix diff --git a/pkgs/development/libraries/SDL_compat/setup-hook.sh b/pkgs/by-name/sd/SDL_compat/setup-hook.sh similarity index 100% rename from pkgs/development/libraries/SDL_compat/setup-hook.sh rename to pkgs/by-name/sd/SDL_compat/setup-hook.sh diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index d0cbfba5ab7ad..6cba631e167d3 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -23454,8 +23454,6 @@ with pkgs; libGLU = null; }); - SDL_compat = callPackage ../development/libraries/SDL_compat { }; - SDL = SDL_classic; SDL2 = callPackage ../development/libraries/SDL2 { From ad2899f18282c4585bb4f7ceb924ea04f8c59e68 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Wed, 4 Sep 2024 12:23:01 -0300 Subject: [PATCH 04/14] SDL_compat: rewrite - finalAttrs design pattern - get rid of nested with in meta --- pkgs/by-name/sd/SDL_compat/package.nix | 40 +++++++++++++------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/pkgs/by-name/sd/SDL_compat/package.nix b/pkgs/by-name/sd/SDL_compat/package.nix index a5f3d6360f892..a2ac5f6d2887d 100644 --- a/pkgs/by-name/sd/SDL_compat/package.nix +++ b/pkgs/by-name/sd/SDL_compat/package.nix @@ -1,39 +1,39 @@ { lib -, stdenv -, fetchFromGitHub -, cmake -, pkg-config , SDL2 +, cmake +, darwin +, fetchFromGitHub +, libGLU , libiconv , mesa +, pkg-config +, stdenv +# Boolean flags , libGLSupported ? lib.elem stdenv.hostPlatform.system mesa.meta.platforms , openglSupport ? libGLSupported -, libGLU -, darwin }: let - inherit (lib) optionals makeLibraryPath; inherit (darwin.apple_sdk.frameworks) Cocoa; inherit (darwin) autoSignDarwinBinariesHook; in -stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "SDL_compat"; version = "1.2.68"; src = fetchFromGitHub { owner = "libsdl-org"; repo = "sdl12-compat"; - rev = "release-" + version; + rev = "release-" + finalAttrs.version; hash = "sha256-f2dl3L7/qoYNl4sjik1npcW/W09zsEumiV9jHuKnUmM="; }; nativeBuildInputs = [ cmake pkg-config ] - ++ optionals (stdenv.isDarwin && stdenv.isAarch64) [ autoSignDarwinBinariesHook ]; + ++ lib.optionals (stdenv.isDarwin && stdenv.isAarch64) [ autoSignDarwinBinariesHook ]; propagatedBuildInputs = [ SDL2 ] - ++ optionals stdenv.hostPlatform.isDarwin [ libiconv Cocoa ] - ++ optionals openglSupport [ libGLU ]; + ++ lib.optionals stdenv.hostPlatform.isDarwin [ libiconv Cocoa ] + ++ lib.optionals openglSupport [ libGLU ]; enableParallelBuilding = true; @@ -43,20 +43,20 @@ stdenv.mkDerivation rec { for lib in $out/lib/*${stdenv.hostPlatform.extensions.sharedLibrary}* ; do if [[ -L "$lib" ]]; then ${if stdenv.hostPlatform.isDarwin then '' - install_name_tool ${lib.strings.concatMapStrings (x: " -add_rpath ${makeLibraryPath [x]} ") propagatedBuildInputs} "$lib" + install_name_tool ${lib.strings.concatMapStrings (x: " -add_rpath ${lib.makeLibraryPath [x]} ") finalAttrs.propagatedBuildInputs} "$lib" '' else '' - patchelf --set-rpath "$(patchelf --print-rpath $lib):${makeLibraryPath propagatedBuildInputs}" "$lib" + patchelf --set-rpath "$(patchelf --print-rpath $lib):${lib.makeLibraryPath finalAttrs.propagatedBuildInputs}" "$lib" ''} fi done ''; - meta = with lib; { + meta = { + homepage = "https://www.libsdl.org/"; description = "Cross-platform multimedia library - build SDL 1.2 applications against 2.0"; + license = lib.licenses.zlib; mainProgram = "sdl-config"; - homepage = "https://www.libsdl.org/"; - license = licenses.zlib; - maintainers = with maintainers; [ peterhoeg ]; - platforms = platforms.all; + maintainers = lib.teams.sdl.members ++ (with lib.maintainers; [ peterhoeg ]); + platforms = lib.platforms.all; }; -} +}) From 245276a92526f1f1eb4cfa58836a70b5165653dc Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Tue, 3 Sep 2024 14:07:21 -0300 Subject: [PATCH 05/14] SDL_classic: hide parameters under package expression --- pkgs/development/libraries/SDL/default.nix | 7 +++++-- pkgs/top-level/all-packages.nix | 7 +------ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/pkgs/development/libraries/SDL/default.nix b/pkgs/development/libraries/SDL/default.nix index 8038407090b43..90d164523a794 100644 --- a/pkgs/development/libraries/SDL/default.nix +++ b/pkgs/development/libraries/SDL/default.nix @@ -5,16 +5,19 @@ , x11Support ? !stdenv.isCygwin && !stdenv.hostPlatform.isAndroid , libXext, libICE, libXrandr , pulseaudioSupport ? config.pulseaudio or stdenv.isLinux && !stdenv.hostPlatform.isAndroid && lib.meta.availableOn stdenv.hostPlatform libpulseaudio, libpulseaudio -, OpenGL, GLUT, CoreAudio, CoreServices, AudioUnit, Kernel, Cocoa +, darwin }: # NOTE: When editing this expression see if the same change applies to # SDL2 expression too let + inherit (darwin.apple_sdk.frameworks) OpenGL CoreAudio CoreServices AudioUnit Kernel Cocoa GLUT; extraPropagatedBuildInputs = [ ] ++ lib.optionals x11Support [ libXext libICE libXrandr ] - ++ lib.optionals (openglSupport && stdenv.isLinux) [ libGL libGLU ] + ++ lib.optionals (openglSupport && stdenv.isLinux) [ libGL ] + # libGLU doesn’t work with Android's SDL + ++ lib.optionals (openglSupport && stdenv.isLinux && (!stdenv.hostPlatform.isAndroid)) [ libGLU ] ++ lib.optionals (openglSupport && stdenv.isDarwin) [ OpenGL GLUT ] ++ lib.optional alsaSupport alsa-lib ++ lib.optional pulseaudioSupport libpulseaudio diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 6cba631e167d3..2b24f02e0d464 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -23447,12 +23447,7 @@ with pkgs; scope-lite = callPackage ../development/libraries/scope-lite { }; - SDL_classic = callPackage ../development/libraries/SDL ({ - inherit (darwin.apple_sdk.frameworks) OpenGL CoreAudio CoreServices AudioUnit Kernel Cocoa GLUT; - } // lib.optionalAttrs stdenv.hostPlatform.isAndroid { - # libGLU doesn’t work with Android’s SDL - libGLU = null; - }); + SDL_classic = callPackage ../development/libraries/SDL { }; SDL = SDL_classic; From 7159facf92be49324a6e5b544dc7952e25ed8c66 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Tue, 3 Sep 2024 15:04:51 -0300 Subject: [PATCH 06/14] SDL1: migrate to by-name And green-alias both SDL1 and SDL_classic to it. --- .../libraries/SDL => by-name/sd/SDL1}/find-headers.patch | 0 .../libraries/SDL/default.nix => by-name/sd/SDL1/package.nix} | 0 .../libraries/SDL => by-name/sd/SDL1}/setup-hook.sh | 0 pkgs/top-level/all-packages.nix | 4 ++-- 4 files changed, 2 insertions(+), 2 deletions(-) rename pkgs/{development/libraries/SDL => by-name/sd/SDL1}/find-headers.patch (100%) rename pkgs/{development/libraries/SDL/default.nix => by-name/sd/SDL1/package.nix} (100%) rename pkgs/{development/libraries/SDL => by-name/sd/SDL1}/setup-hook.sh (100%) diff --git a/pkgs/development/libraries/SDL/find-headers.patch b/pkgs/by-name/sd/SDL1/find-headers.patch similarity index 100% rename from pkgs/development/libraries/SDL/find-headers.patch rename to pkgs/by-name/sd/SDL1/find-headers.patch diff --git a/pkgs/development/libraries/SDL/default.nix b/pkgs/by-name/sd/SDL1/package.nix similarity index 100% rename from pkgs/development/libraries/SDL/default.nix rename to pkgs/by-name/sd/SDL1/package.nix diff --git a/pkgs/development/libraries/SDL/setup-hook.sh b/pkgs/by-name/sd/SDL1/setup-hook.sh similarity index 100% rename from pkgs/development/libraries/SDL/setup-hook.sh rename to pkgs/by-name/sd/SDL1/setup-hook.sh diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 2b24f02e0d464..1167731903c5e 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -23447,9 +23447,9 @@ with pkgs; scope-lite = callPackage ../development/libraries/scope-lite { }; - SDL_classic = callPackage ../development/libraries/SDL { }; + SDL = SDL1; - SDL = SDL_classic; + SDL_classic = SDL1; SDL2 = callPackage ../development/libraries/SDL2 { inherit (darwin.apple_sdk.frameworks) AudioUnit Cocoa CoreAudio CoreServices ForceFeedback OpenGL; From 3108fc275f0c16658bd92ec7a987d6b61a697578 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Wed, 4 Sep 2024 14:03:03 -0300 Subject: [PATCH 07/14] SDL1: rework input set --- pkgs/by-name/sd/SDL1/package.nix | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/pkgs/by-name/sd/SDL1/package.nix b/pkgs/by-name/sd/SDL1/package.nix index 90d164523a794..c6bd9c6907109 100644 --- a/pkgs/by-name/sd/SDL1/package.nix +++ b/pkgs/by-name/sd/SDL1/package.nix @@ -1,11 +1,26 @@ -{ lib, stdenv, config, fetchurl, fetchpatch, pkg-config, audiofile, libcap, libiconv +{ lib +, alsa-lib +, audiofile +, config +, darwin +, fetchpatch +, fetchurl +, libGL +, libGLU +, libICE +, libXext +, libXrandr +, libcap +, libiconv +, libpulseaudio +, pkg-config +, stdenv +# Boolean flags +, alsaSupport ? stdenv.isLinux && !stdenv.hostPlatform.isAndroid , libGLSupported ? lib.meta.availableOn stdenv.hostPlatform libGL -, openglSupport ? libGLSupported, libGL, libGLU -, alsaSupport ? stdenv.isLinux && !stdenv.hostPlatform.isAndroid, alsa-lib +, openglSupport ? libGLSupported +, pulseaudioSupport ? config.pulseaudio or stdenv.isLinux && !stdenv.hostPlatform.isAndroid && lib.meta.availableOn stdenv.hostPlatform libpulseaudio , x11Support ? !stdenv.isCygwin && !stdenv.hostPlatform.isAndroid -, libXext, libICE, libXrandr -, pulseaudioSupport ? config.pulseaudio or stdenv.isLinux && !stdenv.hostPlatform.isAndroid && lib.meta.availableOn stdenv.hostPlatform libpulseaudio, libpulseaudio -, darwin }: # NOTE: When editing this expression see if the same change applies to From 2de9476bf87c495c21e573eb2c6b5211589447e4 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Wed, 4 Sep 2024 14:04:03 -0300 Subject: [PATCH 08/14] SDL1: move rpath next to its usage --- pkgs/by-name/sd/SDL1/package.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/sd/SDL1/package.nix b/pkgs/by-name/sd/SDL1/package.nix index c6bd9c6907109..8783b42ffec36 100644 --- a/pkgs/by-name/sd/SDL1/package.nix +++ b/pkgs/by-name/sd/SDL1/package.nix @@ -37,7 +37,6 @@ let ++ lib.optional alsaSupport alsa-lib ++ lib.optional pulseaudioSupport libpulseaudio ++ lib.optional stdenv.isDarwin Cocoa; - rpath = lib.makeLibraryPath extraPropagatedBuildInputs; in stdenv.mkDerivation rec { @@ -129,7 +128,9 @@ stdenv.mkDerivation rec { ''; # See the same place in the expression for SDL2 - postFixup = '' + postFixup = let + rpath = lib.makeLibraryPath extraPropagatedBuildInputs; + in '' for lib in $out/lib/*.so* ; do if [[ -L "$lib" ]]; then patchelf --set-rpath "$(patchelf --print-rpath $lib):${rpath}" "$lib" From 4ca394d2564cdd14a688b7ce16d3f97e3feb8342 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Wed, 4 Sep 2024 14:07:22 -0300 Subject: [PATCH 09/14] SDL1: finalAttrs design pattern --- pkgs/by-name/sd/SDL1/package.nix | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/sd/SDL1/package.nix b/pkgs/by-name/sd/SDL1/package.nix index 8783b42ffec36..8a437092a5214 100644 --- a/pkgs/by-name/sd/SDL1/package.nix +++ b/pkgs/by-name/sd/SDL1/package.nix @@ -38,14 +38,13 @@ let ++ lib.optional pulseaudioSupport libpulseaudio ++ lib.optional stdenv.isDarwin Cocoa; in - -stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "SDL"; version = "1.2.15"; src = fetchurl { - url = "https://www.libsdl.org/release/${pname}-${version}.tar.gz"; - sha256 = "005d993xcac8236fpvd1iawkz4wqjybkpn8dbwaliqz5jfkidlyn"; + url = "https://www.libsdl.org/release/SDL-${finalAttrs.version}.tar.gz"; + hash = "sha256-1tMWp5Pl40gVXw3ZO5eXmJM/uYqh7evMEIgp1kdKrQA="; }; outputs = [ "out" "dev" ]; @@ -152,4 +151,4 @@ stdenv.mkDerivation rec { platforms = platforms.unix; license = licenses.lgpl21; }; -} +}) From 0af8b6e06bb1bebe783bf6c66b17ff335433414d Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Wed, 4 Sep 2024 14:08:37 -0300 Subject: [PATCH 10/14] SDL1: get rid of nested with in meta --- pkgs/by-name/sd/SDL1/package.nix | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/sd/SDL1/package.nix b/pkgs/by-name/sd/SDL1/package.nix index 8a437092a5214..449ee6db0afdf 100644 --- a/pkgs/by-name/sd/SDL1/package.nix +++ b/pkgs/by-name/sd/SDL1/package.nix @@ -143,12 +143,12 @@ stdenv.mkDerivation (finalAttrs: { enableParallelBuilding = true; - meta = with lib; { + meta = { + homepage = "http://www.libsdl.org/"; description = "Cross-platform multimedia library"; + license = lib.licenses.lgpl21; mainProgram = "sdl-config"; - homepage = "http://www.libsdl.org/"; - maintainers = with maintainers; [ lovek323 ]; - platforms = platforms.unix; - license = licenses.lgpl21; + maintainers = lib.teams.sdl.members ++ (with lib.maintainers; [ lovek323 ]); + platforms = lib.platforms.unix; }; }) From 83c5ee361cafe48101bd9b2f650805947f9503c9 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Wed, 4 Sep 2024 14:09:25 -0300 Subject: [PATCH 11/14] SDL1: hammering --- pkgs/by-name/sd/SDL1/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/sd/SDL1/package.nix b/pkgs/by-name/sd/SDL1/package.nix index 449ee6db0afdf..705d7fe9b3a16 100644 --- a/pkgs/by-name/sd/SDL1/package.nix +++ b/pkgs/by-name/sd/SDL1/package.nix @@ -122,6 +122,8 @@ stdenv.mkDerivation (finalAttrs: { }) ]; + enableParallelBuilding = true; + postInstall = '' moveToOutput share/aclocal "$dev" ''; @@ -141,8 +143,6 @@ stdenv.mkDerivation (finalAttrs: { passthru = { inherit openglSupport; }; - enableParallelBuilding = true; - meta = { homepage = "http://www.libsdl.org/"; description = "Cross-platform multimedia library"; From 198dd168d59c692809339f32309ca1be5029c858 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Wed, 4 Sep 2024 14:13:30 -0300 Subject: [PATCH 12/14] SDL1: lib.optionals instead of lib.optional --- pkgs/by-name/sd/SDL1/package.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/sd/SDL1/package.nix b/pkgs/by-name/sd/SDL1/package.nix index 705d7fe9b3a16..94b7e03f6e246 100644 --- a/pkgs/by-name/sd/SDL1/package.nix +++ b/pkgs/by-name/sd/SDL1/package.nix @@ -55,8 +55,9 @@ stdenv.mkDerivation (finalAttrs: { propagatedBuildInputs = [ libiconv ] ++ extraPropagatedBuildInputs; - buildInputs = [ ] - ++ lib.optional (!stdenv.hostPlatform.isMinGW && alsaSupport) audiofile + buildInputs = + [ ] + ++ lib.optionals (!stdenv.hostPlatform.isMinGW && alsaSupport) [ audiofile ] ++ lib.optionals stdenv.isDarwin [ AudioUnit CoreAudio CoreServices Kernel OpenGL ]; configureFlags = [ From 27e300bca20e24dd7731b565293d9cefde92c595 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Tue, 3 Sep 2024 19:28:13 -0300 Subject: [PATCH 13/14] SDL_classic: red-alias it to SDL1 --- pkgs/top-level/aliases.nix | 1 + pkgs/top-level/all-packages.nix | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix index dd4bc389b81ea..ab9843ac0e3dd 100644 --- a/pkgs/top-level/aliases.nix +++ b/pkgs/top-level/aliases.nix @@ -1371,6 +1371,7 @@ mapAliases ({ ### S ### + SDL_classic = SDL1; # Added 2024-09-03 s2n = s2n-tls; # Added 2021-03-03 sandboxfs = throw "'sandboxfs' has been removed due to being unmaintained, consider using linux namespaces for sandboxing instead"; # Added 2024-06-06 sane-backends-git = sane-backends; # Added 2021-02-19 diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 1167731903c5e..e8d5c39f9287c 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -23449,8 +23449,6 @@ with pkgs; SDL = SDL1; - SDL_classic = SDL1; - SDL2 = callPackage ../development/libraries/SDL2 { inherit (darwin.apple_sdk.frameworks) AudioUnit Cocoa CoreAudio CoreServices ForceFeedback OpenGL; }; From 36d40dfc48572c967117a38914e394e92869af94 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Tue, 3 Sep 2024 15:14:14 -0300 Subject: [PATCH 14/14] rott: update commentary citing SDL_classic --- pkgs/games/rott/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/games/rott/default.nix b/pkgs/games/rott/default.nix index 534f14bcb289b..e678994e47f0f 100644 --- a/pkgs/games/rott/default.nix +++ b/pkgs/games/rott/default.nix @@ -40,8 +40,8 @@ stdenv.mkDerivation rec { "SHAREWARE=${if buildShareware then "1" else "0"}" ]; - # when using SDL_compat instead of SDL_classic, SDL_mixer isn't correctly - # detected, but there is no harm just specifying it + # when using SDL_compat instead of SDL1, SDL_mixer isn't correctly detected, + # but there is no harm just specifying it env.NIX_CFLAGS_COMPILE = toString [ "-I${lib.getDev SDL_mixer}/include/SDL" ];