Skip to content

Comments

teams-for-linux: 1.4.27 -> 1.9.5#338089

Merged
philiptaron merged 4 commits intoNixOS:release-24.05from
khaneliman:teams-24
Aug 29, 2024
Merged

teams-for-linux: 1.4.27 -> 1.9.5#338089
philiptaron merged 4 commits intoNixOS:release-24.05from
khaneliman:teams-24

Conversation

@khaneliman
Copy link
Contributor

Description of changes

Backport of #337868

Had to manually revert lack of electron.dist and versionCheckHook from unstable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman khaneliman changed the base branch from nixos-24.05 to release-24.05 August 29, 2024 03:25
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 338089 run on x86_64-linux 1

1 package built:
  • teams-for-linux

@philiptaron
Copy link
Contributor

philiptaron commented Aug 29, 2024

I'm going to do a build on x86_64-darwin then merge. It might take a while; my old Mac mini is not super fast.

@philiptaron
Copy link
Contributor

Result of nixpkgs-review pr 338089 run on x86_64-darwin 1

1 package built:
  • teams-for-linux

@philiptaron philiptaron merged commit 2b4231b into NixOS:release-24.05 Aug 29, 2024
@khaneliman khaneliman deleted the teams-24 branch August 29, 2024 04:09
@ofborg ofborg bot requested review from chvp, muscaln and qjoly August 29, 2024 04:34
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 29, 2024
@emilazy emilazy mentioned this pull request Aug 29, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants